fix: do not wipe the Retro Rewind install when a (re)install fails - #311
Open
patchzyy wants to merge 2 commits into
Open
fix: do not wipe the Retro Rewind install when a (re)install fails#311patchzyy wants to merge 2 commits into
patchzyy wants to merge 2 commits into
Conversation
Move the current install (and its wiiDisc xml) to RetroRewind6.old instead of deleting it, and only delete that backup once the install succeeded. RemoveAsync now returns a real result instead of always returning Ok().
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR: A failed reinstall deleted the Retro Rewind folder (including
RetroRewind6/Patches, so the users synced mod patches) and then reported success, leaving users with nothing when the server was unreachable.How to Test: Go offline (or block the RR server) and hit "Reinstall Retro Rewind" in the settings. The existing install and patches should still be there afterwards, and you now get an error popup.
What Has Been Changed:
InstallAsyncmoves the current install and its wiiDisc xml toRetroRewind6.oldinstead of deleting them, deletes that backup only after the install succeeded, and restores it when the install fails or is cancelled (leftover backups from an interrupted run are cleaned up first).RemoveAsyncnow returns a real result instead of always returningOk(), and the reinstall button surfaces failures. Added tests for these cases.Related Issue: N/A