fix: write RFL_DB.dat and rksys.dat atomically - #310
Open
patchzyy wants to merge 1 commit into
Open
Conversation
Both save files were rewritten in place, so an interrupted write left a truncated file and lost all Miis or all licenses. Writes now go through a temp file that is flushed and swapped in with File.Replace, keeping a .bak. Also refuse to save rksys.dat when the buffer is not exactly RksysSize.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
RFL_DB.dat and rksys.dat were rewritten in place on every Mii edit / license change, so a crash or full disk mid-write left a truncated file and lost all Miis or all four licenses.
What Changed
New
IFileSystem.WriteAllBytesAtomichelper writes to a.tmp, flushes it, then swaps it in withFile.Replacekeeping a.bak(plain move when the file is new).MiiRepositoryServiceandSaveRksysToFilenow use it, and rksys.dat is no longer written at all when the buffer is not exactlyRksysSize.How to Test
Edit/rename a Mii and rename a license; both save correctly and leave a
.baknext to the file, no.tmpleftovers.dotnet testpasses (177 tests, 3 new).