Skip to content

chore(examples): remove the unused 'query-core' dependency from lit and render the devtools in algolia - #12410

Merged
sukvvon merged 1 commit into
mainfrom
chore/examples-unused-dependencies
Oct 27, 2026
Merged

sukvvon merged 1 commit into
mainfrom
chore/examples-unused-dependencies

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 27, 2026

Copy link
Copy Markdown
Member

🎯 Changes

Resolve dependencies the examples declare but never import.

  • lit/{basic,pagination,ssr}: remove @tanstack/query-core from dependencies. The examples only import @tanstack/lit-query, which already depends on it.
  • react/algolia: @tanstack/react-query-devtools was declared but never rendered. Render <ReactQueryDevtools initialIsOpen /> in App, like the other React examples.
  • preact/algolia: add @tanstack/preact-query-devtools and render <PreactQueryDevtools initialIsOpen /> the same way.
  • pnpm-lock.yaml: drop the lit examples' @tanstack/query-core links and add the preact/algolia devtools link.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@sukvvon sukvvon self-assigned this Oct 27, 2026
@changeset-bot

changeset-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b4e174d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit b4e174d

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 7m 19s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-27 00:52:50 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

8 package(s) bumped directly, 16 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/angular-query-experimental 5.105.0 → 5.105.1 Changeset
@tanstack/lit-query 0.2.31 → 0.2.32 Changeset
@tanstack/preact-query 5.105.0 → 5.105.1 Changeset
@tanstack/query-core 5.105.0 → 5.105.1 Changeset
@tanstack/react-query 5.105.0 → 5.105.1 Changeset
@tanstack/solid-query 5.105.0 → 5.105.1 Changeset
@tanstack/svelte-query 6.3.6 → 6.3.7 Changeset
@tanstack/vue-query 5.105.0 → 5.105.1 Changeset
@tanstack/eslint-plugin-query 5.105.0 → 5.105.1 Dependent
@tanstack/preact-query-devtools 5.105.0 → 5.105.1 Dependent
@tanstack/preact-query-persist-client 5.105.0 → 5.105.1 Dependent
@tanstack/query-async-storage-persister 5.105.0 → 5.105.1 Dependent
@tanstack/query-broadcast-client-experimental 5.105.0 → 5.105.1 Dependent
@tanstack/query-devtools 5.105.0 → 5.105.1 Dependent
@tanstack/query-persist-client-core 5.105.0 → 5.105.1 Dependent
@tanstack/query-sync-storage-persister 5.105.0 → 5.105.1 Dependent
@tanstack/react-query-devtools 5.105.0 → 5.105.1 Dependent
@tanstack/react-query-next-experimental 5.105.0 → 5.105.1 Dependent
@tanstack/react-query-persist-client 5.105.0 → 5.105.1 Dependent
@tanstack/solid-query-devtools 5.105.0 → 5.105.1 Dependent
@tanstack/solid-query-persist-client 5.105.0 → 5.105.1 Dependent
@tanstack/svelte-query-devtools 6.3.6 → 6.3.7 Dependent
@tanstack/svelte-query-persist-client 6.3.6 → 6.3.7 Dependent
@tanstack/vue-query-devtools 6.3.6 → 6.3.7 Dependent

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 27, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12410

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12410

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12410

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12410

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12410

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12410

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12410

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12410

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12410

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12410

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12410

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12410

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12410

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12410

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12410

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12410

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12410

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12410

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12410

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12410

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12410

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12410

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12410

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12410

commit: b4e174d

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.75 KB (0%)
react minimal 8.6 KB (0%)

@sukvvon
sukvvon merged commit 378e950 into main Oct 27, 2026
8 of 9 checks passed
@sukvvon
sukvvon deleted the chore/examples-unused-dependencies branch October 27, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant