fix: drop stale compMiriams in mergeCompartments - #685
Merged
Conversation
mergeCompartments rebuilds comps, compNames and compOutside for the single merged 'System' compartment but left compMiriams untouched, so a model with per-compartment MIRIAM annotations came out with a compMiriams still at the original number of compartments while comps was length 1. That desync breaks downstream permuteModel/exportModel/writeYAMLmodel. The annotations no longer apply once every compartment is merged into one, so the field is now dropped.
Function test results290 tests 264 ✅ 1m 8s ⏱️ Results for commit f26902f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
mergeCompartmentsrebuiltcomps/compNames/compOutsidefor the single merged compartment but leftcompMiriamsat the original length, desyncing it fromcompsand breaking downstreampermuteModel/exportModel/writeYAMLmodel. The per-compartment annotations no longer apply once everything is merged, so the field is dropped.tManipulation.m.Instructions on merging this PR:
develop3as target branch, and will be resolved with a squash-merge.