Skip to content

FEAT: [Admin] #100 add functionality to add new content elements between existing ones - #165

Open
crydotsnake wants to merge 2 commits into
Sylius:1.2from
crydotsnake:feature/100/add-functionality-to-add-new-content-elements-between-existing-ones
Open

FEAT: [Admin] #100 add functionality to add new content elements between existing ones#165
crydotsnake wants to merge 2 commits into
Sylius:1.2from
crydotsnake:feature/100/add-functionality-to-add-new-content-elements-between-existing-ones

Conversation

@crydotsnake

@crydotsnake crydotsnake commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets partially #100
License MIT

This PR adds the feature to add new content elements between existing ones.

image

@crydotsnake
crydotsnake requested a review from a team as a code owner May 17, 2026 08:42
@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch 3 times, most recently from 19d79e8 to 609e2c7 Compare May 17, 2026 08:54
@crydotsnake crydotsnake mentioned this pull request May 17, 2026
Closed
@crydotsnake
crydotsnake marked this pull request as draft May 17, 2026 09:10
@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch 2 times, most recently from 3195c22 to 9a66d96 Compare May 17, 2026 13:08
@crydotsnake
crydotsnake marked this pull request as ready for review May 17, 2026 13:14
@crydotsnake
crydotsnake requested a review from Wojdylak May 19, 2026 10:39
@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch from 9a66d96 to 72b2117 Compare May 19, 2026 10:46
@crydotsnake crydotsnake added Admin Admin Panel related issues and PRs. DX Issues and PRs aimed at improving Developer eXperience. Feature New feature proposals. labels Jun 21, 2026
PiotrTulacz
PiotrTulacz reviewed Jun 23, 2026
View reviewed changes
Comment thread tests/Behat/Element/Admin/ContentElementsCollectionElement.php Outdated
@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch from 72b2117 to e8e74cb Compare June 24, 2026 16:02
@crydotsnake
crydotsnake marked this pull request as draft June 24, 2026 16:16
@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch 2 times, most recently from a98f97a to ec28752 Compare June 24, 2026 17:15
@crydotsnake
crydotsnake marked this pull request as ready for review June 25, 2026 06:04
@crydotsnake
crydotsnake requested a review from PiotrTulacz June 25, 2026 06:04
@crydotsnake

crydotsnake commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@PiotrTulacz @TheMilek can you guys have a look again and test it?

I'm not sure why the Behat test is now failin.

TheMilek
TheMilek reviewed Jul 3, 2026
View reviewed changes
Comment thread templates/admin/macros/insert_element_divider.html.twig Outdated
Comment thread src/Twig/Component/Trait/ContentElementsCollectionFormComponentTrait.php
@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch from d2ed480 to 9700ad3 Compare July 3, 2026 12:17
@crydotsnake
crydotsnake requested a review from TheMilek July 3, 2026 12:17
@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch from 9700ad3 to 3c64336 Compare July 3, 2026 16:37
@crydotsnake

crydotsnake commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

I can not find the issue with the behat test :/

I'm not even sure if its related to my changes as the failing test is # features/admin/block/managing_blocks.feature:42 and
# features/admin/block/managing_blocks.feature:47

This is also interesting:
image

@crydotsnake

crydotsnake commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@TheMilek Build is now green. I dont know why it worked now 🤔

@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch from 6f73681 to f26526b Compare July 6, 2026 06:43
@crydotsnake

crydotsnake commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Commits are now squashed in to one :)

@crydotsnake

crydotsnake commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@TheMilek Build is now green. I dont know why it worked now 🤔

Now its failing again..

@crydotsnake
crydotsnake marked this pull request as draft July 21, 2026 05:53
@crydotsnake

crydotsnake commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

Todos:

@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch 2 times, most recently from fdb66b1 to 5c0c26c Compare July 21, 2026 06:56
@crydotsnake
crydotsnake marked this pull request as ready for review July 21, 2026 07:10
@crydotsnake
crydotsnake requested a review from GSadee July 21, 2026 07:11
@crydotsnake

crydotsnake commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

I'm not sure if the failing behat test is because of my changes 🤔

@crydotsnake crydotsnake reopened this Jul 21, 2026
@crydotsnake crydotsnake added UX Issues and PRs aimed at improving User eXperience. and removed DX Issues and PRs aimed at improving Developer eXperience. labels Jul 21, 2026
@SzymonFilipek

SzymonFilipek commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Hi, @crydotsnake!
I have conducted a QA of this new feature after fixes from PR #197.
The feature itself seems to be working fine, as adding new elements above and between existing ones is possible and doesn't result in errors.
However, moving content elements (even when adding new element wasn't used) seems to be a little broken. For example here, trying to move the first element to the second position results in it moving to the bottom. Also, later it is impossible to move it past the other element.
CMSmoving-elements.webm
I think that it is related to this new feature, because moving elements is working fine on the 1.2 branch after fixes.
Could you check what might be causing that?
Thank you in advance!

@crydotsnake

crydotsnake commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

Hi, @crydotsnake! I have conducted a QA of this new feature after fixes from PR #197. The feature itself seems to be working fine, as adding new elements above and between existing ones is possible and doesn't result in errors. However, moving content elements (even when adding new element wasn't used) seems to be a little broken. For example here, trying to move the first element to the second position results in it moving to the bottom. Also, later it is impossible to move it past the other element. CMSmoving-elements.webm I think that it is related to this new feature, because moving elements is working fine on the 1.2 branch after fixes. Could you check what might be causing that? Thank you in advance!

Hi @SzymonFilipek !

Thank you for your feedback! Yes, i will take a look at it :)

crydotsnake and others added 2 commits July 22, 2026 13:19
@crydotsnake
FEAT: [Admin] Sylius#100 add functionality to add new content element…
fd925a2 
…s between existing ones

refactor: improve element moving logic

chore: apply suggestion review from TheMilek

Co-authored-by: Kamil Grygierzec <53942444+TheMilek@users.noreply.github.com>

FIX: style attribute in ux_icon

FIX: insert new content element at correct position instead of at the end

translation: add missing german translation for add_element

[Behat] Fix test files after rebase
@crydotsnake
[ECS] apply PHP ECS fixe
b05146b
@crydotsnake
crydotsnake force-pushed the feature/100/add-functionality-to-add-new-content-elements-between-existing-ones branch from 9dbb30e to b05146b Compare July 22, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wojdylak Wojdylak Awaiting requested review from Wojdylak
@PiotrTulacz PiotrTulacz Awaiting requested review from PiotrTulacz
@TheMilek TheMilek Awaiting requested review from TheMilek
@GSadee GSadee Awaiting requested review from GSadee

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Admin Admin Panel related issues and PRs. Feature New feature proposals. UX Issues and PRs aimed at improving User eXperience.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crydotsnake @SzymonFilipek @TheMilek @PiotrTulacz @GSadee