fix(sync): cascade series exceptions on provider delete#2398
Merged
Conversation
Provider scope=all deletes removed the master after Google confirmed but left local exception rows (Google instance overrides) active, so range reads kept showing orphans. Mirror the cloud delete cascade. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scope=all), Sync now cascadesfindSeriesExceptions: clear occurrence rows, delete exception events, then delete the master (same order as cloud series delete).Why
Staging cutover found Google instance overrides left active after Compass deleted the series. Pull cannot heal once the master is gone. Browser DELETE 503 with backend 204 remains reporting noise; this is the real blocking Sync gap.
Test plan
bun test:sync -- packages/sync/src/domain/provider-command.service.db.test.tsbun test:sync(full suite)Made with Cursor