feat: wire manifest readinessProbe to remote session controller#1135
Open
SalimKayal wants to merge 3 commits into
Open
feat: wire manifest readinessProbe to remote session controller#1135SalimKayal wants to merge 3 commits into
SalimKayal wants to merge 3 commits into
Conversation
Scope: Core feature — the RSC /ready endpoint becomes aware of the remote session's serving state. - api/v1alpha1/amaltheasession_children.go: inject RSC_SESSION_PORT, RSC_SESSION_URL_PATH, and RSC_READINESS_PROBE_TYPE into the RSC container - internal/remote/config/config.go: add SessionPort, SessionURLPath, ReadinessProbeType to RemoteSessionControllerConfig; register flags/env vars - internal/remote/server/server.go: rework /ready handler with switch on ReadinessProbeType (none/tcp/http/default) - internal/remote/server/server_test.go: add TestReadyEndpoint with 11 test cases
Scope: Prevent invalid probe types from being silently accepted; test the new config surface. - internal/remote/config/config.go: add ReadinessProbeType enum validation in Validate() (reject values other than "", none, tcp, http) - internal/remote/config/config_test.go: add TestConfigNewFlags covering defaults, CLI flags, env vars (RSC_READINESS_PROBE_TYPE, RSC_SESSION_PORT, RSC_SESSION_URL_PATH), and validation errors
SalimKayal
force-pushed
the
salimkayal-feat-allow-readiness-probe-on-http
branch
from
52f77c3 to
589f4a5
Compare
SalimKayal
force-pushed
the
salimkayal-feat-allow-readiness-probe-on-http
branch
from
589f4a5 to
c09c795
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The AmaltheaSession CRD already exposes spec.session.readinessProbe, spec.session.port, and spec.session.urlPath. These fields were previously only honored for local sessions (through Kubernetes container probes). This PR forwards the same values into the remote session controller sidecar so its /ready HTTP endpoint reports readiness based on whether the actual remote session is reachable.
Motivation and Context
For remote sessions managed via FirecREST / RunAI / Slurm, the controller pod was always reporting ready immediately, even if the IDE on the remote compute node had not started yet. We need the Kubernetes readiness state to reflect real user-facing session availability so that ingress and service routing only start once the session is actually usable.
Changes
Tests
Compatibility
Notes