Repository navigation
fix: hide overwrite log - #1535
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the _add function in swanlab/data/run/exp.py to prevent overwriting existing data steps. Instead of allowing overwrites, the function now returns an error if a duplicate step is detected. A review comment suggests removing the now-unreachable commented-out code block to improve code clarity and maintainability.
Comment on lines
+146
to
+150
| # # 允许 overwrite，但区分显式指定和隐式的碰撞 | ||
| # if explicit_step: | ||
| # swanlog.debug(f"Step {step} on key {key} already exists, overwriting.") | ||
| # else: | ||
| # swanlog.warning(f"Implicit step {step} on key {key} resolved as overwrite, but expected to append.") |
Contributor
There was a problem hiding this comment.
This block of commented-out code is unreachable due to the return statement on the preceding line. It should be removed to improve code clarity and maintainability. Version control can be used to track the history of this logic if it needs to be restored in the future.
SAKURA-CAT
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description