Improve docs (build) and some code#16
Open
benknoble wants to merge 3 commits into
Open
Conversation
Include more for-label requires and use the correct names for ->, listof, and image-element? (the latter of which comes from the cached return value, which invokes image; in the uncached case, a filepath is returned, which is not actually an image-element?).
Preserve the exact content of the string while using a simpler construction. I think ~a (display-style) might be redundant on strings, but without contracts the input might be non-strings, so keep it. Even simpler would be (apply ~a #:separator "\n" s strs), but that changes the hash because it misses the final newline. An uncommitted version used (string-join (map ~a (cons s strs)) "\n" #:after-last "\n") for a similar effect.
When building the documentation, the call to asymptote outputs the pwd and the checksum; this interrupts the new progress bar mechanism in recent Racket versions. Silence it by removing the display entirely. (Perhaps we should provide a function to get the hash or document how it is computed? The function could also accept a side-channel to communicate the hash to, such as a box. Modifying it to return multiple values would be a breaking change.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started because I wanted to remove the
path/md5sumoutput duringraco setup; I made a few other (hopefully minor) modifications along the way.See commits for details. Primary changes: