Skip to content

perf: leave exclude as undefined for ** globs #143

Description

@benmccann

For the **/* benchmark, there doesn't need to be an exclude, but it looks like one is passed to fdir. If it is just left undefined, it looks like it performs about 10% faster because it never has to invoke that function. Throughput on github actions goes from ~40 ops/s -> ~45 ops/s

I should note that tinyglobby is the fastest glob library with or without this improvement 😄

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    performancePotential performance improvement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions