LoRa: DMA-based driver to replace blocking SPI. - #51
Open
MasterUser43 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the blocking/interrupt-driven SPI LoRa driver with a DMA implementation for
lora.c/lora.h, & removinglora_async.c(whose logic was folded intolora.cfor consistency).Adds
LORA_IDLE_MODEas a per-board compile-time macro (STANDBY for FLIGHT_COMPUTER, RX_CONTINUOUS for GROUND_STATION/A0010).Diff is scoped entirely to
lora/— no changes outside the LoRa driver w/ this specific PR.Issue Link
Closes #20 (LoRa: Switch to DMA)
Testing
Builds clean (
make clean && makeinapp/rev2) & flashes/verifies successfully to an A0002 rev2 board (STM32H750VBT6). Preset upload over SDECv2 confirmed working (feature bitmask + LoRa params both land).TX itself is not yet verified. This PR should not be pushed until Tx at minimum is verified with a board that has an operational LoRa chip. Will re-test and update this PR once actually testing. Artifacts of testing are present in the build and will be removed once testing is settled.
AI Disclosure (Required)
Other
PR is meant to be left as open.
Reviewer Checklist
Standards
Accuracy
Error Handling
Memory
Performance