GHI #112, #119 - Fix API data pipeline & add altitude tape [FV/typescript-rewrite] - #116
Open
ETSells wants to merge 6 commits into
Open
GHI #112, #119 - Fix API data pipeline & add altitude tape [FV/typescript-rewrite]#116ETSells wants to merge 6 commits into
ETSells wants to merge 6 commits into
Conversation
24 tasks
Member
Author
|
Parent has been moved out of draft state and is ready for review. One minor tweak was needed here, but this is also still ready |
ETSells
force-pushed
the
integration/state-estims-telemetry
branch
from
August 17, 2026 19:51
f1f8190 to
621937c
Compare
Member
Author
|
@favillat Re-requesting review now that the base branch is ready to go. |
Member
Author
|
@NArmistead @MasterUser43 As this is top priority, I'm tagging both of you on the review as well. Please take a look and let me know if there's anything you don't feel you have sufficient expertise in. |
…ult system units to feet/g-force for flight.
favillat
force-pushed
the
integration/state-estims-telemetry
branch
from
August 20, 2026 17:57
621937c to
0f55948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: #112, #119 (relates to: #44, #101)
Parent: SunDevilRocketry/Flight-Computer-Firmware#301
Description
Adds an altitude tape widget to the right of the renderer, fixes the new data pipeline from the API, adds the remaining data readouts to the sensor readings widget, and fixes some responsiveness issues.
Due to a lack of response on the original and the need to build on existing changes, additional features have been added on top of this PR:
a. Ideally, we'll include settings page linkage once that exists, but for now this already helps unify our view/presenter framework a bit.
b. All unit converters implement an interface that defines the base functions, so polymorphism is possible.
c. The altitude converter also includes a ground reference "QFE" mode in addition to the usual sea-level reference "QNH" mode.
NOTE: Builds fail due to an issue that predates this PR and should be fixed by the owner of the target branch. No new errors are generated by this PR, and
npm run devstill works.Originator Checklist
Not all features introduced here have a relevant issue.
No unit test framework exists for this project, so unit tests have not been written.
Manually performed system & integration tests.