GHI #106 - TypeScript Rewrite [main] - #108
Conversation
ts_quat_demo.mp4demo showing off main function of dashboard, properly reading dashboard dump csv, needs to be tested on actual fc |
|
We've fixed the quats on another PR in this stack, in case the new changes conflict. Will take a look when I can |
This reverts commit 4f7683c.
ETSells
left a comment
ETSells
left a comment
There was a problem hiding this comment.
Apologies for the push to this branch, I needed to clear a merge conflict. Nick and I have tested the quat renderer pretty extensively on the stacked PR, so I made a partial reversion to your branch here.
This is a pretty clean conversion and I'm really happy with how it's turned out! Typescript has been a lot easier for me to work with when required.
General notes:
- We should make a push for better documentation from here on out via things like JavaDoc style comments.
- We should also take better advantage of object oriented design principles for models/backend logic.
Other than all that, it looks good to me!
| import type { ReactNode } from "react"; | ||
| import "./styles/globals.css"; | ||
|
|
||
| export const metadata: Metadata = { |
There was a problem hiding this comment.
might wanna define this all finally
|
I would rather get this in now and then defer the refactor. There's a stacked PR that's blocking firmware really badly right now that I'd like to get in as soon as possible |
|
sounds good I kinda figured this took priority. weird question...would you happen to be in chens class rn? |
|
are you behind me bro |
2 participants
Issue: #106
Description
Migrating from JavaScript to TypeScript improves code quality, reliability, and maintainability by introducing static type checking that catches many errors during development rather than at runtime. It also enhances the developer experience through better IDE support, including autocompletion, inline documentation, refactoring tools, and improved code navigation. As projects grow, TypeScript's explicit type definitions and interfaces make the codebase easier to understand, maintain, and onboard new contributors to. Additionally, its strong ecosystem support across modern frameworks and tools makes it a practical choice for long-term development. Finally, Js Sucks like a lot for development and testing.
Originator Checklist