[MacOS] Normalize native app bundle paths - #2790
Open
vvitovec wants to merge 2 commits into
Open
Conversation
vvitovec
force-pushed
the
codex/macos-app-layout
branch
from
July 3, 2026 21:47
4be97c1 to
d37ec81
Compare
vvitovec
changed the title
Contributor
Author
|
Rebased this onto current master and narrowed it to native macOS app-bundle path normalization only. I also kept the layout/executable lookup details private so the public helper surface stays small. No Wine fallback or emulation support is included here, following the feedback on #2794. |
vvitovec
marked this pull request as ready for review
July 3, 2026 21:58
Contributor
Author
|
The PR check appears to have been cancelled while it was still queued for the self-hosted runner. I tried to rerun it from my side, but GitHub requires repository admin rights for that. Could a maintainer rerun the check when a runner is available? |
Collaborator
|
We don't have anyone hosting the runner. I'm cancelling all the jobs until we can host it again. Don't have an ETA. |
vvitovec
force-pushed
the
codex/macos-app-layout
branch
from
July 6, 2026 20:14
d37ec81 to
275411a
Compare
Test Results260 tests 253 ✅ 14s ⏱️ Results for commit 275411a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Subnauticafolder orSubnautica.appresolves toSubnautica.app/Contents.HasValidGameFolder,HasGameExecutable, andNormalizeGamePath.Context
This PR is intentionally limited to the native macOS app-bundle layout. I dropped Wine fallback/emulation work from this stack after maintainer feedback, because the macOS game build is native.
Validation
git diff --checkdotnetis not installed in this local environment.