Skip to content

Add Conduit - #142

Merged
StarCpt merged 3 commits into
StarCpt:mainfrom
arsnekfcn:add-conduit
Jul 2, 2026
Merged

Add Conduit#142
StarCpt merged 3 commits into
StarCpt:mainfrom
arsnekfcn:add-conduit

Conversation

@arsnekfcn

Copy link
Copy Markdown
Contributor

Conduit: a generic, format-agnostic Custom Data pipe. Forwards any block Custom Data tagged [CDT:<tag>] to a backend you run (HTTPS POST) or a local file, reading only on grids you can vanilla-access (own/faction, reachable, per-block share-aware). Senses nothing itself, emits no positions, bring-your-own-backend.

Source: https://github.com/arsnekfcn/Conduit (pinned to d925ab3).


Note: This is a drastically scope-reduced version of my previous PR to add "Quartermaster." I opened a new branch/PR as it's drastically different, and I decided to change the name as the plugin does no parsing or data manipulation on its own.

The plugin does a lot less now, hopefully in compliance with the standards of the PluginHub. It now only reads tagged Custom Data, which can be written by whatever in-game mechanism a user desires (script, manual, making the interns do it).

@StarCpt
StarCpt self-requested a review June 29, 2026 03:07
@StarCpt

StarCpt commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Pulsar already has Newtonsoft.Json in its libraries, you should remove it from the xml so there's no potential conflict.

@StarCpt

StarCpt commented Jun 29, 2026

Copy link
Copy Markdown
Owner

In Scanner.CanAccess, you may want to check if the antenna is functional and powered (.IsFunctional and .IsWorking) in addition to Enabled and EnableBroadcasting.

@StarCpt

StarCpt commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Question: Why not check if the suit antenna is online? You can't remotely access grids without it, even if the grid is broadcasting.

@arsnekfcn

Copy link
Copy Markdown
Contributor Author

Good calls on both, should be easy adds. Will do tomorrow when I get the chance

@StarCpt

StarCpt commented Jun 29, 2026

Copy link
Copy Markdown
Owner

For the config menu, you should implement Pulsar's OpenConfigDialog method (add a method called OpenConfigDialog() in the class implementing IPlugin, it's automatically detected and called by Pulsar) so that it can be opened through the settings button in the plugins menu and shows up in ctrl+shift+/ plugin config menu list.

@arsnekfcn

Copy link
Copy Markdown
Contributor Author

Updated the pinned commit to a72892b. All review points from this thread are addressed:

  • Removed Newtonsoft.Json from .
  • Antenna access check now requires IsFunctional and IsWorking, not just enabled/broadcasting.
  • Remote access now also requires the player's own antenna to be online (suit antenna, or the piloted ship's), matching vanilla.
  • Implemented OpenConfigDialog() so config opens from the Settings button and the Ctrl+Shift+/ list.

@StarCpt
StarCpt merged commit fcee984 into StarCpt:main Jul 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants