Add Conduit - #142
Conversation
|
Pulsar already has Newtonsoft.Json in its libraries, you should remove it from the xml so there's no potential conflict. |
|
In Scanner.CanAccess, you may want to check if the antenna is functional and powered (.IsFunctional and .IsWorking) in addition to Enabled and EnableBroadcasting. |
|
Question: Why not check if the suit antenna is online? You can't remotely access grids without it, even if the grid is broadcasting. |
|
Good calls on both, should be easy adds. Will do tomorrow when I get the chance |
|
For the config menu, you should implement Pulsar's OpenConfigDialog method (add a method called OpenConfigDialog() in the class implementing IPlugin, it's automatically detected and called by Pulsar) so that it can be opened through the settings button in the plugins menu and shows up in ctrl+shift+/ plugin config menu list. |
|
Updated the pinned commit to a72892b. All review points from this thread are addressed:
|
Conduit: a generic, format-agnostic Custom Data pipe. Forwards any block Custom Data tagged
[CDT:<tag>]to a backend you run (HTTPS POST) or a local file, reading only on grids you can vanilla-access (own/faction, reachable, per-block share-aware). Senses nothing itself, emits no positions, bring-your-own-backend.Source: https://github.com/arsnekfcn/Conduit (pinned to
d925ab3).Note: This is a drastically scope-reduced version of my previous PR to add "Quartermaster." I opened a new branch/PR as it's drastically different, and I decided to change the name as the plugin does no parsing or data manipulation on its own.
The plugin does a lot less now, hopefully in compliance with the standards of the PluginHub. It now only reads tagged Custom Data, which can be written by whatever in-game mechanism a user desires (script, manual, making the interns do it).