refactor(format): centralize number formatting - #720
Open
Marvelg256 wants to merge 1 commit into
Open
Conversation
Extract shared formatDecimals, formatCurrency, and formatPercent functions into src/lib/format.ts. Replace inline .toFixed calls in quote and status views with the new shared helpers. Refactor formatStroops to delegate to formatDecimals internally, eliminating the last raw toFixed in the module. - formatDecimals(value, fractionDigits): fixed decimal places + thousands separators - formatCurrency(value, symbol): currency amount (2 decimals) with configurable suffix - formatPercent(decimal, fractionDigits): decimal-to-percentage with % suffix 25 tests, 100% coverage. No new dependencies. Output unchanged. Closes StableRoute-Org#496
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract shared formatDecimals, formatCurrency, and formatPercent functions into src/lib/format.ts. Replace inline .toFixed calls in quote and status views with the new shared helpers. Refactor formatStroops to delegate to formatDecimals internally, eliminating the last raw toFixed in the module.
25 tests, 100% coverage. No new dependencies. Output unchanged.
Closes #496
Summary
Related Issue
Type Of Change
Testing
npm run lintnpm testnpm run buildContributor Checklist
type/area-slugwhere possible.Notes For Reviewers
💬 Join the StableRoute Discord for questions, reviews, and faster merges.