fix: iec62443 text header parity — "IEC 62443 Gap Report" (v0.5.33)#43
Merged
Conversation
go-FuSa TestRunIEC62443_TextDefault checks strings.Contains(out, "IEC 62443 Gap Report"). The old header "IEC 62443-4-2 Gap Report" did not contain that substring because "-4-2 " separates "62443" from "Gap". Changed to "IEC 62443 Gap Report — %s (target %s, profile 4-2)". Signed-off-by: Matt Jones <matt@jellybaby.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cfusa iec62443text output header changed from"IEC 62443-4-2 Gap Report"to"IEC 62443 Gap Report — … (profile 4-2)"so go-FuSa'sTestRunIEC62443_TextDefaultsubstring check passesRoot cause
strings.Contains(out, "IEC 62443 Gap Report")requires the substring"IEC 62443 Gap Report"to be present verbatim. The old string"IEC 62443-4-2 Gap Report"splits62443fromGapwith-4-2, so the check failed.Test plan
cfusa iec62443text output contains"IEC 62443 Gap Report"-4-2info preserved in suffix(profile 4-2)