Fix shard price in tooltips#2518
Conversation
Alex33856
left a comment
Alex33856
left a comment
There was a problem hiding this comment.
This should probably be its own config option, right?
|
To me that feels like unnecessary bloat, maybe renaming the option to a more generic name might be better? |
yeah that's probably fine. |
532ec51 to
6f823da
Compare
LifeIsAParadox
added
merge me please
LifeIsAParadox
added
reviews needed
LifeIsAParadox
added
merge me please
| "skyblocker.config.general.itemTooltip.avg.THREE_DAY": "3-day price", | ||
| "skyblocker.config.general.itemTooltip.craft": "Crafting Cost", | ||
| "skyblocker.config.general.itemTooltip.craft.@Tooltip": "You can choose which Bazaar order type to use in crafting calculation", | ||
| "skyblocker.config.general.itemTooltip.craft": "Calculated Costs", |
There was a problem hiding this comment.
On second thought I don't like this. This rename obscures the tooltip option into something wildly different than it actually is (which is that it shows the raw crafting cost).
There was a problem hiding this comment.
Would you rather I split crafting cost in tooltip into one option and whether calculations use buy order or buy instantly prices into a second option? I can do that if you want.
LifeIsAParadox
added
changes requested
|
Decided it was better left unchanged. |
4 participants
fixes #2474
Tests
Option set to Buy Order
Option set to Buy Instantly