Repository navigation
fix(ui): count failed hosts and workloads apart in rollout dialogs - #837
Merged
Merged
Conversation
Retry, Skip this phase, Expedite and Roll back confirmations tallied every unit as a host, so failed placements read as "N failed hosts" listing cluster names. units::tally counts hosts, clusters and workloads apart and names placements "workload on cluster". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WkowUuST81Z3SBP92m6Tyv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben · project thread
Rollout confirmation dialogs tallied every unit as a host, so a failed placement read as "N failed hosts (nomad, …)".
logic::units::tallycounts hosts, clusters and workloads apart, naming placementsworkload on cluster:2 failed hosts (pi-1, pi-2) and 1 failed workload (grafana on nomad).Generated by Claude Code