Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
CI Plots |
Physics Metrics Comparison2 configuration(s) have differences
Configurations with Differences
|
ShipReco.py now fits tracks and vertices with ACTS and finds tracks with the Segments pattern recognition unless told otherwise. The Segments pattern recognition finds more tracks with fewer ghosts than GenFit with AR at every multiplicity, and ACTS is always part of the pixi environment. --trackFitter genfit still runs the GenFit chain and falls back to AR when --patRec is not given. GenFit and the FH, AR and TemplateMatching pattern recognition are deprecated, and ShipReco.py warns when they are used. run_tracking_benchmark.py and the ci-reco task follow the new defaults. BREAKING CHANGE: reco files contain RecoTracks and RecoVertices instead of FitTracks unless --trackFitter genfit is passed. Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
…o.py knows --patRec accepted any string, so a typo only failed once ShipReco.py ran, after the simulation step. Give it the same choices as ShipReco.py so argparse rejects bad values up front. The default stays None, leaving the choice between Segments and AR to ShipReco.py. Assisted-by: Claude Code:claude-opus-5-5
cc0360f to
4e31d4f
Compare
|
I'd propose this for merging Thursday at the review to also have input from the PC. |





























































































































































🤖 AI text below 🤖
ShipReco.py now fits tracks and vertices with ACTS and finds tracks with the
Segments pattern recognition by default. GenFit tracking and vertexing, and
the FH, AR and TemplateMatching pattern recognition, are deprecated.
Segments finds more tracks than GenFit with AR at every multiplicity, with
fewer ghosts (see the 26.10 changelog), and ACTS is always in the pixi
environment.
--trackFitter genfitstill runs the GenFit chain. Without--patRecitfalls back to AR, so the old behaviour needs only the fitter flag.
recognition is used.
run_tracking_benchmark.pyand theci-recotask use the new defaults.Breaking: reco files contain
RecoTracks/RecoVerticesinstead ofFitTracksunless--trackFitter genfitis passed. ShipAna and the analysistools read both formats.
Summary by CodeRabbit
Changes
Deprecations