Skip to content

feat(reco)!: make ACTS the default tracking and vertexing - #1549

Open
olantwin wants to merge 3 commits into
mainfrom
feat/acts-default-tracking
Open

olantwin wants to merge 3 commits into
mainfrom
feat/acts-default-tracking

Conversation

@olantwin

@olantwin olantwin commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🤖 AI text below 🤖

ShipReco.py now fits tracks and vertices with ACTS and finds tracks with the
Segments pattern recognition by default. GenFit tracking and vertexing, and
the FH, AR and TemplateMatching pattern recognition, are deprecated.

Segments finds more tracks than GenFit with AR at every multiplicity, with
fewer ghosts (see the 26.10 changelog), and ACTS is always in the pixi
environment.

  • --trackFitter genfit still runs the GenFit chain. Without --patRec it
    falls back to AR, so the old behaviour needs only the fitter flag.
  • ShipReco.py prints a FutureWarning when GenFit or a deprecated pattern
    recognition is used.
  • run_tracking_benchmark.py and the ci-reco task use the new defaults.

Breaking: reco files contain RecoTracks/RecoVertices instead of
FitTracks unless --trackFitter genfit is passed. ShipAna and the analysis
tools read both formats.

Summary by CodeRabbit

  • Changes

    • Reconstruction and tracking benchmarks now default to ACTS fitting, with Segments pattern recognition. Selecting GenFit restores the GenFit chain and defaults pattern recognition to AR, unless another option is specified.
  • Deprecations

    • GenFit tracking and vertexing, along with FH, AR, and TemplateMatching pattern recognition, are deprecated. Selecting these options triggers a warning.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Tracking reconstruction now defaults to ACTS fitting. When pattern recognition is unspecified, ShipReco.py selects Segments for ACTS and AR for GenFit. The benchmark, CI command, and digi-reconstruction default are updated. Deprecated options remain available and trigger warnings in ShipReco.py.

Changes: Tracking defaults

Layer / File(s) Summary
Select fitter and pattern-recognition defaults
macro/ShipReco.py, python/shipDigiReco.py, CMakeLists.txt, CHANGELOG.md
ShipReco.py defaults to ACTS and selects Segments for ACTS or AR for GenFit when pattern recognition is unspecified. It emits FutureWarnings for GenFit and the deprecated pattern-recognition options. Digi reconstruction defaults to ACTS when no fitter is set. The changelog records the defaults and deprecations, and the CMake comment identifies ACTS as the default fitter.
Use defaults in benchmark and CI
macro/run_tracking_benchmark.py, pixi.toml
The benchmark defaults to ACTS and passes --patRec only when specified. The CI command no longer passes --patRec AR.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Benchmark as run_tracking_benchmark.py
  participant ShipReco
  participant Reconstruction
  Benchmark->>ShipReco: pass ACTS fitter and optional pattern-recognition selection
  ShipReco->>ShipReco: select Segments when pattern recognition is unspecified
  ShipReco->>Reconstruction: run with selected fitter and pattern recognition
Loading
Merge Risk: Minimal · up to 4e31d

This change makes ACTS fitting with Segments pattern recognition the default and keeps GenFit available through an option. The documented output change from FitTracks to RecoTracks is intended. No merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: ACTS becomes the default for tracking and vertexing in ShipReco.py. The changeset matches this. It switches the default track fitter to acts, sets Segments as the defa…
Description check Passed The description covers the main content of the change. It states the new ACTS and Segments defaults, the deprecations of GenFit and FH/AR/TemplateMatching, the warnings, the benchmark and ci-reco upda…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: ACTS becomes the default for tracking and vertexing in ShipReco.py. The changeset matches this. It switches the default track fitter to acts, sets Segments as the default pattern recognizer for acts, and updates the benchmark, pixi task, and shipDigiReco defaults. The title also carries the conventional-commit breaking marker (!), which matches the breaking change described in the PR description.

Full details: Description check

Explanation

The description covers the main content of the change. It states the new ACTS and Segments defaults, the deprecations of GenFit and FH/AR/TemplateMatching, the warnings, the benchmark and ci-reco updates, and the breaking change for output files. It follows the repository template only partly: the checklist is not visibly ticked, and the description does not confirm that the changelog was updated, although the raw summary shows CHANGELOG.md was modified. It also does not state whether the commit message follows conventional commits, though the title uses that format.

Resolution

Optionally tick the checklist items in the description. Confirm the changelog update and the conventional commit format explicitly so that the template is fully met.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3f1bbd81-b4ad-4639-815d-2c0492314f9b
Commits

Reviewing files that changed from the base of the PR and between cc0360f and 4e31d4f.

Files selected for processing: 3

  • CHANGELOG.md
  • macro/run_tracking_benchmark.py
  • pixi.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

CI Plots

View all plots

fixed-target

pixi

PlaneHA10011 PlaneHA11011 PlaneHA12011 PlaneHA20011 PlaneHA21011 PlaneHA22011 PlaneHA10012 PlaneHA11012 PlaneHA12012 PlaneHA20012 PlaneHA21012 PlaneHA22012 PlaneHA10013 PlaneHA11013 PlaneHA12013 PlaneHA20013 PlaneHA21013 PlaneHA22013 PlaneHA10014 PlaneHA11014 PlaneHA12014 PlaneHA20014 PlaneHA21014 PlaneHA22014 PlaneHA10015 PlaneHA11015 PlaneHA12015 PlaneHA20015 PlaneHA21015 PlaneHA22015 PlaneHA10016 PlaneHA11016 PlaneHA12016 PlaneHA20016 PlaneHA21016 PlaneHA22016 PlaneHA10017 PlaneHA11017 PlaneHA12017 PlaneHA20017 PlaneHA21017 PlaneHA22017 PlaneHA10022 PlaneHA11022 PlaneHA12022 PlaneHA10111 PlaneHA11111 PlaneHA12111 PlaneHA10221 PlaneHA11221 PlaneHA12221 PlaneHA10223 PlaneHA11223 PlaneHA12223 PlaneHA10331 PlaneHA11331 PlaneHA12331 PlaneHA10211 PlaneHA11211 PlaneHA12211 PlaneHA20211 PlaneHA21211 PlaneHA22211 PlaneHA10321 PlaneHA11321 PlaneHA12321 PlaneHA20321 PlaneHA21321 PlaneHA22321 PlaneHA12212 PlaneHA13212 PlaneHA14212 PlaneHA22212 PlaneHA23212 PlaneHA24212

sim-chain

helium-all-TRY_2026

distu distv disty nmeas chi2 delPOverP pullPOverPx pullPOverPy pullPOverPz delPOverP2 delPOverPz delPOverP2z chi2 prob IP Vzresol Vxresol Vyresol Vzpull Vxpull Vypull Doca IP0 HNL IP0_pi0 HNL_pi0 HNLw meas meas2 measVSchi2 distu distv disty meanhits extrapTimeDetX extrapTimeDetY oa nrtracks nrSBT pi0Mass delPOverPz_py delPOverP2z_py pullPOverPx_py pullPOverPy_py pullPOverPz_py

vacuums-all-TRY_2026

distu distv disty nmeas chi2 delPOverP pullPOverPx pullPOverPy pullPOverPz delPOverP2 delPOverPz delPOverP2z chi2 prob IP Vzresol Vxresol Vyresol Vzpull Vxpull Vypull Doca IP0 HNL IP0_pi0 HNL_pi0 HNLw meas meas2 measVSchi2 distu distv disty meanhits extrapTimeDetX extrapTimeDetY oa nrtracks nrSBT pi0Mass delPOverPz_py delPOverP2z_py pullPOverPx_py pullPOverPy_py pullPOverPz_py

tracking-benchmark

pixi

h_dp_over_p h_dp_vs_p h_dx h_dy h_dtx h_dty h_hit_residual h_hit_pull h_chi2ndf h_p_truth h_p_matched h_p_correct_charge h_p_wrong_charge h_vtx_dx h_vtx_dy h_vtx_dz h_doca h_mass_rel

@github-actions

Copy link
Copy Markdown
Contributor

Physics Metrics Comparison

2 configuration(s) have differences

  • Configurations compared: 2
  • With differences: 2

Configurations with Differences

comparison_helium-all-TRY_2026

  • Files compared: 4
  • Histograms compared: 34
  • Fits compared: 3
  • Total differences: 43
Show differences
recohists.root:
  nmeas.mean: 25.77±0.3142 → 30.55±0.1837 (13.1σ)
  nmeas.rms: 3.541±0.2222 → 2.029±0.1299 (5.9σ)
  nmeas.integral: 127 → 122 (Δ=3.937%)
  chi2.rms: 0.505±0.03169 → 0.3362±0.02152 (4.4σ)
  chi2.integral: 127 → 122 (Δ=3.937%)

sim_ci-test_ana.root:
  chi2.integral: 0.002577 → 0.002843 (Δ=10.28%)
  prob.integral: 109 → 121 (Δ=11.01%)
  IP.integral: 109 → 121 (Δ=11.01%)
  Vzresol.integral: 29 → 36 (Δ=24.14%)
  Vxresol.integral: 30 → 36 (Δ=20%)
  ... and 32 more

sim_ci-test_rec.root:
  ship_reco_sim.branches: 18 → 19

comparison_vacuums-all-TRY_2026

  • Files compared: 4
  • Histograms compared: 34
  • Fits compared: 3
  • Total differences: 41
Show differences
recohists.root:
  nmeas.mean: 25.23±0.3596 → 30.78±0.1693 (14.0σ)
  nmeas.rms: 4.004±0.2543 → 1.823±0.1197 (7.8σ)
  nmeas.integral: 124 → 116 (Δ=6.452%)
  chi2.integral: 124 → 116 (Δ=6.452%)

sim_ci-test_ana.root:
  chi2.rms: 0.2423±0.01987 → 0.4752±0.03658 (5.6σ)
  chi2.integral: 0.002396 → 0.002692 (Δ=12.35%)
  prob.integral: 102 → 116 (Δ=13.73%)
  IP.integral: 99 → 112 (Δ=13.13%)
  Vzresol.integral: 27 → 36 (Δ=33.33%)
  ... and 31 more

sim_ci-test_rec.root:
  ship_reco_sim.branches: 18 → 19


About this comparison

Physics metrics are extracted from ROOT files and compared.
Default comparison uses 5% tolerance for histogram statistics
and 3σ for fit parameters.

Metrics stored in git notes: refs/notes/ci/physics-metrics/<config>

Comment thread macro/run_tracking_benchmark.py Resolved
ShipReco.py now fits tracks and vertices with ACTS and finds tracks with
the Segments pattern recognition unless told otherwise. The Segments
pattern recognition finds more tracks with fewer ghosts than GenFit with
AR at every multiplicity, and ACTS is always part of the pixi
environment.

--trackFitter genfit still runs the GenFit chain and falls back to AR
when --patRec is not given. GenFit and the FH, AR and TemplateMatching
pattern recognition are deprecated, and ShipReco.py warns when they are
used. run_tracking_benchmark.py and the ci-reco task follow the new
defaults.

BREAKING CHANGE: reco files contain RecoTracks and RecoVertices instead
of FitTracks unless --trackFitter genfit is passed.

Assisted-by: Claude Code:claude-opus-5-5
…o.py knows

--patRec accepted any string, so a typo only failed once ShipReco.py ran,
after the simulation step. Give it the same choices as ShipReco.py so
argparse rejects bad values up front. The default stays None, leaving
the choice between Segments and AR to ShipReco.py.

Assisted-by: Claude Code:claude-opus-5-5
@olantwin
olantwin force-pushed the feat/acts-default-tracking branch from cc0360f to 4e31d4f Compare November 14, 2026 21:16
@olantwin

Copy link
Copy Markdown
Contributor Author

I'd propose this for merging Thursday at the review to also have input from the PC.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants