feat: add turnkey support#715
Conversation
✅ Deploy Preview for jolly-shaw-20fe62 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| activeFee.value = await relayer.value?.getFeeEstimate(tokenAddress); | ||
| isFeeLoading.value = false; | ||
| try { | ||
| activeFee.value = await relayer.value?.getFeeEstimate(tokenAddress); |
There was a problem hiding this comment.
I think this can race. Expanding the row starts one fee request, then starting the withdrawal starts another. If the first one finishes last, it can overwrite the fee for the active withdrawal. Could we keep the fee for this withdrawal as its own value and pass that through confirmation/signing? A test with two out-of-order fee responses would catch it.
marcomariscal
left a comment
There was a problem hiding this comment.
Looks good. The fee estimate race is addressed with the isolated withdrawal fee and out-of-order response test.
There was a problem hiding this comment.
@garyghayrat Tested myself with Optimism and Mainnet. Funded the wallet across all accounts. Let's coordinate on Monday to get it rolled out to prod.
No description provided.