Skip to content

NonlinearSolveBase: unwrap FunctionWrappersWrapper on the EnzymeOriginator adjoint path (MTK DAE init) #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
May 31, 2026
Merged

NonlinearSolveBase: unwrap FunctionWrappersWrapper on the EnzymeOriginator adjoint path (MTK DAE init) #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/NonlinearSolveBase/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "NonlinearSolveBase"
uuid = "be0214bd-f91f-a760-ac4e-3421ce2b2da0"
version = "2.30.0"
version = "2.30.1"
authors = ["Avik Pal <avikpal@mit.edu> and contributors"]

[deps]
Expand Down
13 changes: 13 additions & 0 deletions lib/NonlinearSolveBase/src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,19 @@ function _solve_adjoint(
alg = extract_alg(args, kwargs, prob.kwargs)
_prob = get_concrete_problem(prob; u0 = u0, p = p, kwargs...)

# Enzyme cannot differentiate through FunctionWrappers' `llvmcall`, so its
# traced forward solve runs on the unwrapped function (see
# `maybe_unwrap_prob_for_enzyme`, #940). That unwrap is keyed off the solver's
# own autodiff, which for an MTK DAE initialization is ForwardDiff even when
# the *outer* differentiation is Enzyme — so it does not fire here. Key off
# the originator instead: the EnzymeOriginator adjoint primal must have the
# same (unwrapped) type as Enzyme's traced forward, otherwise the custom
# `solve_up` rule's returned primal type mismatches the inferred return type
# (`EnzymeRuntimeException: Expected return type of primal to be ...`).
if originator isa SciMLBase.EnzymeOriginator && is_fw_wrapped(_prob.f.f)
@set! _prob.f.f = get_raw_f(_prob.f.f)
end

if has_kwargs(_prob)
kwargs = isempty(_prob.kwargs) ? kwargs : merge(values(_prob.kwargs), kwargs)
end
Expand Down
Loading