Skip to content

Feat(#64): RabbitMQ 이벤트에 evidenceCards 필드 추가 - #75

Merged
kite-pp merged 1 commit into
developfrom
feat/64-evidence-cards-rabbitmq
Aug 14, 2026
Merged

Feat(#64): RabbitMQ 이벤트에 evidenceCards 필드 추가#75
kite-pp merged 1 commit into
developfrom
feat/64-evidence-cards-rabbitmq

Conversation

@kite-pp

@kite-pp kite-pp commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • REST 응답에는 이미 노출되던 증거 카드(evidence)가 RabbitMQ AnalysisResultPayload에는 매핑되지 않아 Spring에 전달되지 않고 있던 문제 해결
  • Spring PR #102(머지·배포 완료)에서 합의한 계약 그대로 구현: evidenceCardsAnalysisResultPayload 최상위에 추가 (institutionMatch와 달리 규칙/URL/텍스트 트랙을 모두 아우르므로 ruleAnalysis 하위가 아님)
  • EvidenceCardDetail(category, title, description) 스키마, result_factory.py에서 result.evidence 매핑 (category는 enum → .value)

Spring이 이미 반영·배포된 상태라 배포 순서 조건(Spring 먼저) 충족 — 이 PR은 머지 후 바로 배포해도 됩니다.

Refs #64

Test plan

  • pytest tests/infrastructure/rabbitmq/ (91 passed)
  • 전체 스위트 pytest (599 passed, 3 deselected)
  • build_evidence()_evidence_cards() 수동 통합 확인

Summary by CodeRabbit

  • New Features
    • Analysis results now include evidence cards with a category, title, and description.
    • Results without evidence display an empty evidence card list.
    • Failed analyses do not include evidence cards.

REST 응답(SmishingAnalysisResponse.evidence)에는 이미 노출되던 증거
카드가 RabbitMQ AnalysisResultPayload에는 매핑되지 않아 Spring에
전달되지 않고 있었다. Spring PR #102(머지·배포됨)에서 합의한 대로
필드를 구현한다.

- EvidenceCardDetail 스키마 추가 (category/title/description)
- AnalysisResultPayload 최상위에 evidenceCards로 연결 - institutionMatch와
  달리 규칙/URL/텍스트 트랙을 모두 아우르는 결과라 ruleAnalysis 하위가
  아닌 최상위 (Spring과 합의된 위치)
- result_factory.py에서 result.evidence(EvidenceItem 리스트)를 매핑,
  category는 enum .value로 변환

Spring이 이미 반영·배포된 상태(PR #102)라 배포 순서 조건 충족.
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 63766dbb-481a-4dad-baf8-94bfd287a093

📥 Commits

Reviewing files that changed from the base of the PR and between 0936602 and 500560d.

📒 Files selected for processing (3)
  • app/infrastructure/rabbitmq/result_factory.py
  • app/infrastructure/rabbitmq/schemas.py
  • tests/infrastructure/rabbitmq/test_result_factory.py

📝 Walkthrough

Walkthrough

The RabbitMQ result payload now includes serialized evidence cards. A new Pydantic schema defines each card, and the result factory maps evidence items or returns an empty list. Tests cover successful and failed executions.

Changes

Evidence card payload support

Layer / File(s) Summary
Evidence card payload contract
app/infrastructure/rabbitmq/schemas.py
Added EvidenceCardDetail with required category, title, and description fields. Added AnalysisResultPayload.evidenceCards with an empty-list default.
Evidence card mapping and validation
app/infrastructure/rabbitmq/result_factory.py, tests/infrastructure/rabbitmq/test_result_factory.py
Mapped result.evidence into EvidenceCardDetail objects. Tests verify mapped fields and empty evidence cards for failed executions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 50056

RabbitMQ 분석 결과에 evidenceCards를 추가하고 기존 증거 카드 데이터를 매핑하는 localized change이며, 관련 테스트가 통과했습니다. 현재 머지를 막는 actionable risk는 없습니다.

Possibly related issues

Suggested reviewers: pearseona

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding the evidenceCards field to RabbitMQ events.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/64-evidence-cards-rabbitmq

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kite-pp
kite-pp merged commit 73f5890 into develop Aug 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant