Skip to content

Repair mission HUD visibility overrides for the current client - #296

Merged
netniV merged 5 commits into
STFC-Mod:devfrom
Guffawaffle:fix/mission-hud-hooks
Oct 11, 2026
Merged

netniV merged 5 commits into
STFC-Mod:devfrom
Guffawaffle:fix/mission-hud-hooks

Conversation

@Guffawaffle

@Guffawaffle Guffawaffle commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Mission HUD visibility overrides stopped installing after the client removed MissionsHudViewController.UpdateButtons. Use the five current lifecycle/setup methods to restore TOML-configured Auto / Always / Never choices for Q's Trials, Field Training, Outposts and Missions. Preserve native calls and Boolean arguments, and retire the removed Daily Goals control.

The existing default-enabled [patches].missionhudtweakshooks switch owns installation independently of feature values. Callbacks reread the configured modes. Complete signature, field-layout and distinct-target checks precede installation; a partial detour failure leaves installed callbacks forwarding native behavior. This is the standalone HUD repair; live settings controls remain separate in #297.

Refreshed against current dev. Validation: Windows release build and all 11 example TOMLs pass. Static hook-fit checks cover all five detour targets on the matching installed Windows client 271. Earlier integration testing covered HUD/Haven transitions; current refreshed-artifact gameplay and macOS native fit/runtime remain unverified. CI results for the refreshed head are pending.

@Guffawaffle

Guffawaffle commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Hook/feature alignment follow-up for #313

Follow-up to #313: keep hook installation independent of feature enablement, with default-enabled compatibility switches under [patches] and feature checks inside the installed hooks.

Reconcile the HUD lifecycle repair with #313's independent [patches].missionhudtweakshooks. This branch still filters out Auto buttons at startup and returns without installing when no overrides are configured. Preserve every supported button definition and decide behavior from the current [ui].hud_q_trials, hud_field_training, hud_outposts, and hud_missions settings during hook execution. Retain native lifecycle calls and partial-install safeguards. Update this HUD parent first, then propagate it into #297 alongside that branch's separate #282 dependency.

Implemented in 0121a6f. All four supported buttons register under the existing independent missionhudtweakshooks switch; callbacks reread current modes and preserve native work. Complete signatures, field layout and distinct targets are validated before installation; partial installation remains inert. Exact Windows release build, all 11 TOMLs and three independent review lanes passed; CI is queued. Native game/Mac qualification remains open. Next: propagate this parent and corrected #282 into #297.

@Guffawaffle Guffawaffle reopened this Oct 11, 2026
@Guffawaffle
Guffawaffle marked this pull request as ready for review October 11, 2026 03:32
@netniV
netniV merged commit e298381 into STFC-Mod:dev Oct 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants