sssd man-page: Improve man-page for override_gid#8741
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the override_gid configuration option in sssd.conf.5.xml to clarify its behavior and document its default value. The reviewer pointed out a grammatical inconsistency ("supersedes" instead of "supersede") and formatting issues involving mixed tabs and spaces, providing a suggestion to resolve both.
| <listitem> | ||
| <para> | ||
| Override the primary GID value with the one specified. | ||
| Override the primary GID value for all users in this |
There was a problem hiding this comment.
Hi @asakure Do you think it is enough to say Override the primary GID value for all users with this value ?
There was a problem hiding this comment.
Hi @justin-stephenson Yes, it will keep it short. But I think we shall include domain part for example - Override the primary GID value for all users in the domain with specified value. Let me know your opinion.
There was a problem hiding this comment.
Looks good to me, thanks
| the identity provider. | ||
| </para> | ||
| <para> | ||
| Default: not set (SSSD will use the primary GID value |
There was a problem hiding this comment.
Please remove SSSD will I don't think it is worthwhile
asakure
force-pushed
the
man_page_override_gid
branch
from
fb49ef7 to
44866fb
Compare
|
The pull request was accepted by @justin-stephenson with the following PR CI status: 🟡 rpm-build:centos-stream-10-x86_64:upstream (in_progress) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
asakure
force-pushed
the
man_page_override_gid
branch
2 times, most recently
from
96d1ec2 to
73210ac
Compare
justin-stephenson
added
Accepted
Trivial
This commit improves the man-page statement for override_gid option by adding clear description & "Default" value. Resolves: SSSD#7341 Signed-off-by: Akshay Sakure <asakure@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com>
sssd-bot
force-pushed
the
man_page_override_gid
branch
from
73210ac to
e0d7f7f
Compare
4 participants
This commit improves the man-page statement for override_gid option by adding clear description & "Default" value.
Resolves: #7341