Fix the ninja test for console ctrl-c - #4909
Merged
Merged
Conversation
This test failed on MacOS and some Linux distros. Turns out the test was not accurately simulating a real ctrl-C from a terminal. Signed-off-by: Mats Wichmann <mats@linux.com>
mwichmann
added
the
testsuite
Collaborator
Author
|
Irritating to see CI tests fail, but they didn't fail on the test being fixed - this is now running and passing on MacOS; our CI doesn't exercise the non-Ubuntu Linux platforms that were also seeing problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test failed on MacOS and some Linux distros. Turns out the test was not accurately simulating a real ctrl-C from a terminal.
Test-only change, no changes to SCons code or docs.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).