Skip to content

fix: use subprocess instead of os.system in extract_compressed_png.py#269

Closed
orbisai0security wants to merge 1 commit into
SAT-R:mainfrom
orbisai0security:fix-v-002-command-injection-extract-png
Closed

fix: use subprocess instead of os.system in extract_compressed_png.py#269
orbisai0security wants to merge 1 commit into
SAT-R:mainfrom
orbisai0security:fix-v-002-command-injection-extract-png

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix critical severity security issue in scripts/extract_compressed_png.py.

Vulnerability

Field Value
ID V-002
Severity CRITICAL
Scanner multi_agent_ai
Rule V-002
File scripts/extract_compressed_png.py:14

Description: The script uses os.system() with f-string interpolation to execute shell commands. The 'name' and 'base_name' variables are derived from filenames and passed directly into shell commands without any sanitization. Shell metacharacters in filenames are interpreted by the shell, enabling arbitrary command execution.

Changes

  • scripts/extract_compressed_png.py

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by OrbisAI Security
@JaceCear JaceCear closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants