Correct eql? deprecation warning - #1230
Merged
Merged
Conversation
This warning assumes the currencies are not equal. It would be best to make that explicit.
peter-j-fortuna
changed the title
peter-j-fortuna
changed the title
sunny
previously approved these changes
Sep 23, 2026
sunny
left a comment
sunny
left a comment
Member
There was a problem hiding this comment.
Could you add a small entry to the CHANGELOG? 🙏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This warning assumes the currencies are not equal. It would be best to make that explicit.
Currently, we are getting misleading deprecation warnings for Money.new(0, "USD").eql?(Money.new(0, "USD"))