misc unmerged from lineup data - #17
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new ffpy-ingest command-line workflow for fetching league data from ESPN, Yahoo, and Sleeper, optionally persisting normalized results to the existing SQLite database, and printing results in table/JSON/CSV formats. It also adjusts ESPN request cookie handling to avoid sending empty cookies for public leagues.
Changes:
- Add a new
ffpy-ingestCLI with subcommands to ingest leagues and inspect stored leagues/rosters/matchups from the DB. - Add ingest implementations for ESPN (public/private autodetect), Yahoo (OAuth token management), and Sleeper (public API).
- Add output utilities (table/JSON/CSV + DB persistence helper) and auth helpers for cookie/token file storage; register a new console script entry point.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ffpy/integrations/espn_league.py | Avoids sending empty cookies; only attaches cookies when auth is present. |
| src/ffpy/ingest/yahoo.py | Adds Yahoo ingest flow with token refresh + interactive OAuth fallback and normalization. |
| src/ffpy/ingest/sleeper.py | Adds Sleeper ingest flow and normalization with cached player map enrichment. |
| src/ffpy/ingest/output.py | Adds JSON/CSV/table output formatters and DB persistence helper. |
| src/ffpy/ingest/espn.py | Adds ESPN ingest flow with public/private autodetect + cookie prompting and normalization. |
| src/ffpy/ingest/cli.py | Adds ffpy-ingest argparse CLI and DB inspection commands. |
| src/ffpy/ingest/auth.py | Adds token/cookie load/save helpers under ~/.ffpy/. |
| src/ffpy/ingest/init.py | Exposes the new ingest package/modules and documents usage. |
| pyproject.toml | Registers the new ffpy-ingest console script entry point. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…data. Mock get_cfb_roster_seasons so CI no longer fails once 2025 rosters are published. Co-authored-by: Cursor <cursoragent@cursor.com>
Fix docs/subcommand names, typing.Any, token file perms, parent CLI flags, and 401/403-only private-league detection. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.