Skip to content

change impl to support json path on generic value#4

Open
MeirShpilraien wants to merge 30 commits intomasterfrom
generic_json_path
Open

change impl to support json path on generic value#4
MeirShpilraien wants to merge 30 commits intomasterfrom
generic_json_path

Conversation

@MeirShpilraien
Copy link
Copy Markdown

No description provided.

@MeirShpilraien MeirShpilraien requested review from gavrie and gkorland May 4, 2021 14:08
@gavrie gavrie removed their request for review May 4, 2021 14:24
meir@redislabs.com and others added 24 commits May 6, 2021 10:38
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
This reverts commit 4b11540.
Decided this api does not pertain to this trait
Changes needed for ReJSON multi values and multi paths #477
* Avoid panic on unimplemeted filter syntax

* Unimplemeted filter syntax - add unit test

* Unimplemeted filter syntax - add unit test (2)

 cargo test  unimplemented_in_filter
ijson support
* avoid panic on bad filter

* Formatting

* return empty filter token instead of panic

* add test
Comment thread src/select/json_node.rs
Value::Array(_) => SelectValueType::Array,
Value::Object(_) => SelectValueType::Object,
Value::Number(n) => {
if n.is_i64() {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiler-message: error: this if has identical blocks
--> src/select/json_node.rs:16:31
|
16 | if n.is_i64() {
| _______________________________^
17 | | SelectValueType::Long
18 | | } else if n.is_u64() {
| |_________________^
|
= note: #[deny(clippy::if_same_then_else)] on by default
note: same as this
--> src/select/json_node.rs:18:38
|
18 | } else if n.is_u64() {
| _____________________^
19 | | SelectValueType::Long
20 | | } else if n.is_f64() {
| |
^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else

(at-me in a reply with help or ignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants