Skip to content

Support per-point experimental IDT criteria - #214

Merged
alongd merged 1 commit into
mainfrom
i111-per-point-idt
Sep 27, 2026
Merged

alongd merged 1 commit into
mainfrom
i111-per-point-idt

Conversation

@alongd

@alongd alongd commented Sep 27, 2026

Copy link
Copy Markdown
Member

Summary

  • add a versioned, validated per-point experimental IDT format while preserving unversioned behavior
  • simulate shock-tube and post-compression RCM points directly at their own state
  • support source-defined targets and criteria with typed per-point refusals
  • document the format and add an end-to-end example

Verification

  • focused schema and IDT suite: 113 passed
  • changed t3 line coverage: 91.98%
  • ruff and git diff --check: passed
  • full suite at pristine HEAD: 2774 passed; nine failures reproduced on official/main; one multiprocessing test was sandbox-blocked and passed separately outside the sandbox

No Copilot review requested; the repository workflow will handle it after CI.

@github-actions
github-actions Bot requested a lite review from Copilot September 27, 2026 08:43
@codecov-commenter

codecov-commenter commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.66%. Comparing base (4d89b33) to head (619ef06).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   81.55%   81.66%   +0.10%     
==========================================
  Files          78       78              
  Lines       12467    12726     +259     
  Branches     2645     2684      +39     
==========================================
+ Hits        10168    10393     +225     
- Misses       1671     1692      +21     
- Partials      628      641      +13     
Flag Coverage Δ
unittests 81.66% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Address the non-finite time validation, unresolved-criterion classification, and v1 example wiring issues.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Adds versioned, validated per-point experimental IDT criteria while preserving legacy behavior.

Changes:

  • Adds schema validation, unit conversion, and typed refusals.
  • Simulates shock-tube and RCM points directly with source-defined criteria.
  • Adds tests, documentation, and a v1 YAML example.
File Summary
tests/​test_simulate/​test_experimental_idt.py Tests schema validation and end-to-end IDT behavior.
t3/​simulate/​cantera_idt.py Implements per-point simulation and scoring; unresolved criteria need distinct classification from simulation failures.
t3/​schema.py Defines versioned IDT models; non-finite experimental times must be rejected.
examples/​idt_with_experiment/​experimental_idt_v1.yaml Provides the versioned input example.
docs/​input_reference.md Documents the new experimental IDT format.
docs/​examples.md Documents usage; the runnable example should exercise the new v1 input.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread t3/schema.py Outdated
@alongd
alongd requested a lite review from Copilot September 27, 2026 09:52
@alongd
alongd merged commit 503678f into main Sep 27, 2026
5 checks passed
@alongd
alongd deleted the i111-per-point-idt branch September 27, 2026 09:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved critical and moderate findings remain in the schema validation and simulation logic.

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)
Resolved since last review (1)

Comment thread t3/simulate/cantera_idt.py
Comment thread t3/schema.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants