mover: fetch ceph-csi-config via k8s API instead of volume mount #23
Merged
Conversation
The operator no longer mounts the ceph-csi-config ConfigMap as a volume. Instead, it fetches it via the Kubernetes API in the reconcile loop using a shared fetchCSIConfigData helper. The ConfigMap name and namespace are configurable via CEPH_CSI_CONFIG_NAME and CEPH_CSI_CONFIG_NAMESPACE env vars (defaults: ceph-csi-config / rook-ceph), with Makefile placeholder substitution matching the existing MOVER_IMAGE pattern. Mover Job pods remain unchanged - they still mount their per-RS/RD copy. Also increases operator resource limits (cpu: 1000m, memory: 512Mi) and adds VolSync CRD dependencies to the ClusterServiceVersion. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Rakshith R <rar@redhat.com>
setRSPaused, updateManualTrigger, and updateRSManualTrigger do a Get+Update without retry. When the controller updates the resource between those calls, the test hits a 409 Conflict and fails. Wrap each Get+Update in retry.RetryOnConflict to handle the race. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Rakshith R <rar@redhat.com>
Rakshith-R
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator no longer mounts the ceph-csi-config ConfigMap as a volume.
Instead, it fetches it via the Kubernetes API in the reconcile loop using
a shared fetchCSIConfigData helper. The ConfigMap name and namespace are
configurable via CEPH_CSI_CONFIG_NAME and CEPH_CSI_CONFIG_NAMESPACE env
vars (defaults: ceph-csi-config / rook-ceph), with Makefile placeholder
substitution matching the existing MOVER_IMAGE pattern.
Mover Job pods remain unchanged - they still mount their per-RS/RD copy.
Also increases operator resource limits (cpu: 1000m, memory: 512Mi) and
adds VolSync CRD dependencies to the ClusterServiceVersion.
Assisted-by: Claude noreply@anthropic.com
Signed-off-by: Rakshith R rar@redhat.com