[smoke] Replace deprecated -fopenmp-target-ignore-env-vars flag by nicebert · Pull Request #2053 · ROCm/aomp

nicebert · 2026-03-10T12:44:08Z

[smoke] Replace deprecated -fopenmp-target-ignore-env-vars flag

Update 27 tests (19 smoke, 8 smoke-limbo) to use replacement flags
for specialized kernel generation. The -fopenmp-target-ignore-env-vars
flag is removed from ROCm/llvm-project#1698.

Replaced with -fopenmp-assume-teams-oversubscription and
-fopenmp-assume-threads-oversubscription, which provide equivalent
functionality by indicating that the runtime can ignore environment
variables for thread/team configuration, enabling no-loop kernel optimizations.

Depends on: ROCm/llvm-project#1698

ronlieb · 2026-03-10T16:26:31Z

so these need to likely be moved to smok-dev and be landed and merged into aomp:amd-staging,
then the llvm change can come in

dhruvachak · 2026-03-10T16:39:36Z

please provide the correct llvm-project PR link. The current link goes to an AOMP PR.

And yes, as Ron said already, these tests need to be moved to smoke-dev first. Support for the 2 over-subscription flags does not exist in older compilers.

dhruvachak · 2026-03-10T16:42:14Z

What is the deprecation path for ROCm? e.g. does it get added to docs and we wait for a release cycle?

nicebert · 2026-03-13T15:13:39Z

please provide the correct llvm-project PR link. The current link goes to an AOMP PR.

And yes, as Ron said already, these tests need to be moved to smoke-dev first. Support for the 2 over-subscription flags does not exist in older compilers.

sorry, the link in the "depends on" worked correctly, the other one didn't.

dhruvachak · 2026-03-17T19:15:47Z

[smoke] Replace deprecated -fopenmp-target-ignore-env-vars flag

Update 27 tests (19 smoke, 8 smoke-limbo) to use replacement flags for specialized kernel generation. The -fopenmp-target-ignore-env-vars flag is removed from ROCm/llvm-project#1698 as it had no codegen implementation and represented a deprecated approach.

I would not say that ignore-envars had no codegen implementation. It has a corresponding implementation. But it is being replaced with the over-subscription options to be in sync with upstream.

Replaced with -fopenmp-assume-teams-oversubscription and -fopenmp-assume-threads-oversubscription, which provide equivalent functionality by indicating that the runtime can ignore environment variables for thread/team configuration, enabling no-loop and xteam-reduction kernel optimizations.

Xteam does not need this guarantee any more, that is legacy. No-Loop needs this guarantee. So please remove mention of Xteam from here.

Depends on: ROCm/llvm-project#1698

ronlieb

comment says to replace deprecated flag, but i do not see the flags being textually replaced, instead we are adding two flags to some tests ???

nicebert · 2026-05-21T13:03:35Z

I talked to @ronlieb about the test move a few weeks ago, which turned out to not be required after all since the functionality is still present just not under the name of the flag

nicebert · 2026-06-02T12:55:51Z

w.r.t. the deprecation path: should we add a deprecation warning before removing it? then I need to create a new PR first that does this before we can move ahead with the two PRs removing the flag implementation and replacing it with the two upstream variants in the tests

nicebert · 2026-06-04T09:10:35Z

@ronlieb to answer your "change request" about the flag replacement: the flag was used in the implementation as a short cut for the other two flags, so to ensure functional equivalence we need to instead pass those

dhruvachak · 2026-06-05T05:53:35Z

I talked to @ronlieb about the test move a few weeks ago, which turned out to not be required after all since the functionality is still present just not under the name of the flag

But older compilers will fail with the new version of the tests, isn't it? That's because even if older compilers honor those 2 new options from upstream, they don't do anything based on those options. Only newer compilers actually implement anything for those 2 options.

nicebert · 2026-07-27T13:07:14Z

comment says to replace deprecated flag, but i do not see the flags being textually replaced, instead we are adding two flags to some tests ???

I can be more explicit in the message if you'd prefer. Tests that depend on the oversubscription behavior the deprecated flag used to gate got direct replacement. I removed it in tests that didn't require the flag in the first place.

ronlieb · 2026-07-30T11:27:51Z

I talked to @ronlieb about the test move a few weeks ago, which turned out to not be required after all since the functionality is still present just not under the name of the flag

But older compilers will fail with the new version of the tests, isn't it? That's because even if older compilers honor those 2 new options from upstream, they don't do anything based on those options. Only newer compilers actually implement anything for those 2 options.

has this been addressed ?

Update 27 tests (19 smoke, 8 smoke-limbo) to use replacement flags for specialized kernel generation. The -fopenmp-target-ignore-env-vars flag is being replaced with -fopenmp-assume-teams-oversubscription and -fopenmp-assume-threads-oversubscription to sync with upstream LLVM. The replacement flags provide equivalent functionality for no-loop kernel optimizations by indicating that the runtime can ignore environment variables for thread/team configuration.

nicebert · 2026-07-31T10:14:45Z

Squashed the two commits into a single commit and changed two more tests that weren't passing with "older compilers" with the replacement: target-fast still implies ignore-env-vars so negative flag variants did not lead to condition correctly evaluating to false for no-loop kernel gate, replaced target-fast with the explicit flags in those.
Since the assumption flags have been added to the compiler in late 2021 I don't think we need to worry too much about compilers not knowing the replacement flags.

dhruvachak · 2026-08-17T18:45:38Z

 RUNCMD      = ./$(TESTNAME) 2>&1 | $(FILECHECK) $(TESTSRC_MAIN)

-CFLAGS       += -fopenmp-target-fast -fno-openmp-target-ignore-env-vars
+CFLAGS       += -fopenmp-assume-no-thread-state -fopenmp-assume-no-nested-parallelism


This test is checking whether the no-variant works for the option. So now it should have

CFLAGS += -fopenmp-target-fast -fno-openmp-assume-teams-oversubscription -fno-openmp-assume-threads-oversubscription

These -no-options should disable no-loop generation and the test should pass.

dhruvachak · 2026-08-17T18:48:45Z

 RUNCMD      = ./$(TESTNAME) 2>&1 | $(FILECHECK) $(TESTSRC_MAIN)

-CFLAGS       += -O3 -fno-openmp-target-ignore-env-vars -fopenmp-target-fast
+CFLAGS       += -O3  -fopenmp-assume-no-thread-state -fopenmp-assume-no-nested-parallelism


same comment as no-loop4.

dhruvachak · 2026-08-17T18:50:24Z

 TESTSRC_ALL  = $(TESTSRC_MAIN) $(TESTSRC_AUX)

-CFLAGS       += -O3 -fno-openmp-target-ignore-env-vars
+CFLAGS       += -O3


same comment as in no-loop-4/

dhruvachak · 2026-08-17T18:50:54Z

 TESTSRC_ALL  = $(TESTSRC_MAIN) $(TESTSRC_AUX)

-CFLAGS       += -O3 -fno-openmp-target-ignore-env-vars
+CFLAGS       += -O3 


same comment as in no-loop-4.

dhruvachak · 2026-08-17T18:51:24Z

 TESTSRC_ALL  = $(TESTSRC_MAIN) $(TESTSRC_AUX)

-CFLAGS       += -O3 -fno-openmp-target-ignore-env-vars
+CFLAGS       += -O3


dhruvachak · 2026-08-17T18:52:15Z

 TESTSRC_ALL  = $(TESTSRC_MAIN) $(TESTSRC_AUX)

-CFLAGS       += -O3 -fno-openmp-target-ignore-env-vars
+CFLAGS       += -O3


dhruvachak · 2026-08-18T01:34:58Z

I realized that my suggestion for no-loop-4 won't work until ROCm/llvm-project#1698 lands. So there may be a chicken-and-egg situation between these 2 PRs.

One possibility is to ignore my suggestions for this PR, make a mental note to add some coverage for the no-variants of the oversubscription options in the presence of -fopenmp-target-fast, and add that coverage back after the llvm-project PR#1698 lands.

I will approve this PR assuming the above plan.

dhruvachak

LGTM, remember to add coverage for the no-variants of the over-subscription options after ROCm/llvm-project#1698 lands.

nicebert requested review from carlobertolli, estewart08, gregrodgers, ronlieb and zGoldthorpe as code owners March 10, 2026 12:44

ronlieb requested a review from dhruvachak March 10, 2026 15:59

nicebert force-pushed the amd/dev/nicebert/remove-ignore-env-vars-tests branch from 8fe34db to 3e158bf Compare March 17, 2026 12:42

dhruvachak reviewed Mar 17, 2026

View reviewed changes

nicebert force-pushed the amd/dev/nicebert/remove-ignore-env-vars-tests branch from 3e158bf to 744fdb6 Compare March 19, 2026 08:55

ronlieb requested changes Apr 29, 2026

View reviewed changes

nicebert requested review from dhruvachak and ronlieb June 4, 2026 09:10

nicebert force-pushed the amd/dev/nicebert/remove-ignore-env-vars-tests branch from e35eaf7 to 76eb2b0 Compare July 27, 2026 12:45

nicebert changed the base branch from amd-staging to aomp-dev July 27, 2026 12:53

nicebert force-pushed the amd/dev/nicebert/remove-ignore-env-vars-tests branch from 76eb2b0 to b14dc41 Compare July 31, 2026 10:07

ronlieb approved these changes Jul 31, 2026

View reviewed changes

dhruvachak reviewed Aug 17, 2026

View reviewed changes

dhruvachak approved these changes Aug 18, 2026

View reviewed changes

Uh oh!

Conversation

nicebert commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronlieb commented Mar 10, 2026

Uh oh!

dhruvachak commented Mar 10, 2026

Uh oh!

dhruvachak commented Mar 10, 2026

Uh oh!

nicebert commented Mar 13, 2026

Uh oh!

dhruvachak commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ronlieb left a comment

Choose a reason for hiding this comment

Uh oh!

nicebert commented May 21, 2026

Uh oh!

nicebert commented Jun 2, 2026

Uh oh!

nicebert commented Jun 4, 2026

Uh oh!

dhruvachak commented Jun 5, 2026

Uh oh!

nicebert commented Jul 27, 2026

Uh oh!

ronlieb commented Jul 30, 2026

Uh oh!

nicebert commented Jul 31, 2026

Uh oh!

dhruvachak Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

dhruvachak Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

dhruvachak Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

dhruvachak Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

dhruvachak Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

dhruvachak Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

dhruvachak commented Aug 18, 2026

Uh oh!

dhruvachak left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nicebert commented Mar 10, 2026 •

edited

Loading

dhruvachak commented Mar 17, 2026 •

edited

Loading