SM8750: backlight: aw99706: use documented DT property names - #3174
Open
mrdidit wants to merge 1 commit into
Open
SM8750: backlight: aw99706: use documented DT property names#3174mrdidit wants to merge 1 commit into
mrdidit wants to merge 1 commit into
Conversation
mrdidit
marked this pull request as ready for review
August 12, 2026 22:19
mrdidit
changed the title
spycat88
force-pushed
the
next
branch
2 times, most recently
from
August 13, 2026 00:00
c93f6bd to
135d112
Compare
The AW99706 binding uses unit-suffixed property names, but the driver looks up shorter names and silently falls back to defaults. On the KONKR Pocket Fit Elite this ignores the 7000 uA limit and uses the 20000 uA default, programming CFG2 to 0x1e instead of 0x04. Use the documented property names so the existing DTS values apply. Signed-off-by: mrdidit <26687854+mrdidit@users.noreply.github.com>
mrdidit
force-pushed
the
agent/fix-aw99706-dt-properties
branch
from
August 14, 2026 23:18
5a2cbe7 to
b14788a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the AW99706 backlight driver’s Device Tree property lookups to use the documented unit-suffixed names.
On the KONKR Pocket FIT Elite, the mismatch caused the driver to ignore the existing 7000 µA LED-current limit and use its 20000 µA default instead. This programmed CFG2 to
0x1erather than0x04and produced a concentrated, brightness-dependent hotspot above the LCD flex area.Testing
Hardware tested on a KONKR Pocket FIT Elite:
0x04after boot without a manual register write.checkpatchvalidation with no errors or warnings.Additional Context
The AW99706 Device Tree binding defines:
awinic,sw-freq-hzawinic,sw-ilmt-microampawinic,iled-max-microampawinic,uvlo-thres-microvoltThe driver looked for shorter names without the unit suffixes, causing valid Device Tree values to be silently ignored.
The KPFE Device Tree already specifies
awinic,iled-max-microamp = <7000>, so no device-specific DTS workaround is required.AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? YES | PARTIALLY | NO
YES