SM8550: mask the IPCC mailbox irq on suspend (parity with SM8750) - #3115
Merged
Merged
Conversation
The ADSP charger firmware pushes an unsolicited BATTMGR_NOTIFICATION (opcode 0x7) about 0.5s after suspend entry. It rings the IPCC mailbox irq, which upstream is IRQF_NO_SUSPEND, so it is never masked and wakes the device every few minutes. Drop IRQF_NO_SUSPEND so the mailbox irq is masked across system suspend. Lifted from ROCKNIX SM8750 (AYN Odin 3), which shares the battmgr/pmic_glink charger model and sleeps cleanly.
shuuri-labs
force-pushed
the
sm8550-ipcc-suspend-groundwork
branch
from
August 4, 2026 19:08
c6ab69d to
f955f5b
Compare
shuuri-labs
marked this pull request as ready for review
August 4, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Suspend/resume groundwork for SM8550, split out from #2954. One patch, no behavior change on current builds (suspend remains disabled by the SM8550 quirk).
The ADSP charger firmware pushes an unsolicited BATTMGR_NOTIFICATION about 0.5s after suspend entry. The IPCC mailbox irq is IRQF_NO_SUSPEND upstream, so it is never masked across suspend and the notification wakes the device every few minutes, the single biggest blocker to SM8550 staying asleep. Dropping IRQF_NO_SUSPEND lets the PM core mask it like a normal irq; pending signals are handled on resume.
ROCKNIX already carries this patch verbatim for SM8750, so it shouldn't add much new maintenance surface. It is also needed by any future SM8550 suspend path - the charger chatter wakes both deep and s2idle - so whoever continues the suspend work builds on it either way. If a future kernel bump ever makes it fail to apply, dropping it is safe: the only consequence is the old self-wake behavior returning for suspend users.
Testing
Verified on a Retroid Pocket 6 (details in the patch header): before, the device could not stay asleep past 5 to 10 minutes; after, clean RTC-bounded multi-hour deep sleeps with matching boottime drift. No effect on shipping builds, since the quirk keeps suspend off.
AI Usage
Did you use AI tools to help write this code? Yes. AI tools were used for investigation tooling and log correlation; the fix itself is lifted from ROCKNIX's existing SM8750 patch and was validated by hardware testing.