Support "datetime64[{s,ms,us,ns}]" and "timedelta64[{s,ms,us,ns}" aliases - #238
Open
Christian Bourjau (cbourjau) wants to merge 1 commit into
Open
Christian Bourjau (cbourjau) wants to merge 1 commit into
Christian Bourjau (cbourjau) wants to merge 1 commit into
Conversation
lutzgruber-quantco
approved these changes
Sep 16, 2026
Christian Bourjau (cbourjau)
marked this pull request as ready for review
September 16, 2026 16:02
Christian Bourjau (cbourjau)
requested a review
from Sam Gilmour (sgilm)
as a code owner
September 16, 2026 16:02
Christian Bourjau (cbourjau)
enabled auto-merge (squash)
September 16, 2026 16:02
Christian Bourjau (cbourjau)
disabled auto-merge
September 16, 2026 16:03
Sam Gilmour (sgilm)
approved these changes
Sep 17, 2026
Sam Gilmour (sgilm)
left a comment
Sam Gilmour (sgilm)
left a comment
Contributor
There was a problem hiding this comment.
It now occurs to me that we also have from_numpy_dtype doing a similar job to DTYPE_ALIAS_MAP and normalize_dtype. Do you think it would be worth cleaning that up in a future PR? If so I'd be happy to do that.
| ========= | ||
|
|
||
| 0.22.0 (unreleased) | ||
| 0.22.0 (2026-09-16) |
Contributor
There was a problem hiding this comment.
Suggested change
| 0.22.0 (2026-09-16) | |
| 0.22.0 (2026-09-17) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add string aliases for all datetime and timedelta dtypes currently supported by ndonnx. This closes #236 .