Conversation
ngoldbaum
approved these changes
Sep 17, 2026
ngoldbaum
left a comment
ngoldbaum
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, just one suggestion which avoids the mutex, which looks a little odd to me.
| // in the thread pool. | ||
| let iterator_driver = move || { | ||
| let orig_sender = sender.clone(); | ||
| let result = Python::attach(move |iterating_py| { |
Collaborator
There was a problem hiding this comment.
is there a principled reason for the move here? If not I think if you delete it then iterator_driver would implement Fn and you wouldn't need the mutex below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18