Fix NEST/AGenBio trough reservoir well geometry#1045
Merged
Conversation
Definition bugs surfaced by the 3D geometry preview (PR PyLabRobot#1042); these are corrections to the resource definitions themselves, scoped to one PR. - nest_1_troughplate_185000uL_Vb: well_size_x/well_size_y were transposed vs the plate body (127.76 x 85.48), so the single well was rotated 90 deg and overhung the trough; swapped to match the body and the working nest_8/nest_12 convention. - nest_1/nest_8/nest_12_troughplate_*: add cross_section_type=RECTANGLE (defaulted to CIRCLE, so rectangular troughs were modelled/rendered round). - AGenBio_1_troughplate_{190000,100000}uL_Fl: extend well size_z so the cavity reaches the plate rim; pin max_volume to the catalogued spec (190/100 mL) so the now-taller box does not overstate capacity; add the missing compute_volume_from_height to the 100000 def (mirrors the 190000 sibling). - Add concise one-line docstrings + `cat. no.:` provenance to all five. No public API change; geometry and volume models are now correct. ruff/format/mypy/pytest(resources)/docs(-W) all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects resource-definition geometry bugs in the NEST and AGenBio single-/multi-trough reservoirs, surfaced while reviewing the 3D geometry preview in #1042. Scoped to one focused PR; no public API change.
nest_1_troughplate_185000uL_Vb—well_size_x/well_size_ywere transposed relative to the plate body (127.76 × 85.48), so the single well was effectively rotated 90° and overhung the trough (preview bbox 127.76 × 113.92). Swapped to match the body and the workingnest_8/nest_12convention (well is now 108 × 72, inside the body).nest_1/nest_8/nest_12_troughplate_*— addedcross_section_type=CrossSectionType.RECTANGLE; these rectangular troughs were defaulting toCIRCLE, so they were modelled/rendered as round.AGenBio_1_troughplate_190000uL_Fl/_100000uL_Fl— extended wellsize_zso the cavity reaches the plate rim (well top now flush with plate top); pinnedmax_volumeto the catalogued spec (190 mL / 100 mL) so the now-taller box doesn't overstate capacity; added the missingcompute_volume_from_heightto the 100000 def (mirrors the 190000 sibling).cat. no.:provenance to all five defs.Test plan
make format/make format-check— cleanmake lint(ruff) — All checks passedmake typecheck(mypy --check-untyped-defs) — no issues, 488 filespytest pylabrobot/resources— 197 passed, 27 subtestsmake docs-check(-W) — build succeeded🤖 Generated with Claude Code