cleanup: thread []*html.Node through winnow, drop temp Selection#585
Merged
Conversation
winnow only ever reads sel.Nodes; the *Selection parameter was incidental. Change its signature to winnow(nodes []*html.Node, ...) and update its three callers (FilterMatcher, NotMatcher, filterAndPush). filterAndPush no longer needs to fabricate a throwaway Selection to satisfy the call. While this change has o measurable runtime effect, it simplifies the code a bit, by making winnow's signature clearer, and removes a now-useless line and its associated comment in filterAndPush
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
winnow only ever reads sel.Nodes; the *Selection parameter was incidental. Change its signature to winnow(nodes []*html.Node, ...) and update its three callers (FilterMatcher, NotMatcher, filterAndPush). filterAndPush no longer needs to fabricate a throwaway Selection to satisfy the call.
While this change has o measurable runtime effect, it simplifies the code a bit, by making winnow's signature clearer, and removes a now-useless line and its associated comment in filterAndPush