Repository navigation
Conversation
Add a command allowing for configuration to be checked without performing any other operations. This is useful for validating configuration changes separately, e.g. as part of config management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a command allowing for configuration to be checked without performing any other operations. This is useful for validating configuration changes separately, e.g. as part of config management or prior to restarting the service.
I was going to open an issue first to discuss but the implementation is so trivial that I figured I may as well do it first.
I'm not super happy about the actual command
Runfunction being a no-op, but this was the least disruptive change and still means that all the validation happens in one place...This does also alter the behavior of the configuration checking to print all config errors rather than just the first. IMO for a check function this behavior is right, and I think it's also more useful at "proper" run time, but very happy to revert to the previous behavior for all commands other than
checkconfigif preferred.