Fix(mcp): "set all" button now follows active search

[w3joe]

Problem

When a user searched for tools by name and clicked "Set all", the bulk approval action applied to all tools in the installation, not just the filtered results. This made it impossible to bulk-approve a subset of tools by name prefix (e.g. all create_* tools from a Linear MCP server).

Closes #2043

Changes

• useMcpInstallationTools: setBulkApproval now accepts an optional targetTools array. When provided, only those tools are updated; otherwise falls back to all tools (preserving existing behaviour).
• ServerDetailView: when a search is active, the "Set all" buttons pass filteredTools as the target. Tooltips update to say "Approve filtered" / "Require approval for filtered" / "Block filtered" to make the scope clear to the user.

How did you test this?

Manually tested in the app: Settings → MCP Servers → connected server with >5 tools → typed a prefix in the search box → clicked each "Set all" button and confirmed only the matching tools were updated.

Publish to changelog?

No

[greptile-apps]

Comments Outside Diff (1)

1. apps/code/src/renderer/features/mcp-servers/components/parts/ServerDetailView.tsx, line 251-307 (link)

   Repeated inline expression violates OnceAndOnlyOnce

   The expression toolSearch ? filteredTools : undefined (and the disabled predicate bulkPending || filteredTools.length === 0) are each written three times. Extracting them to local variables removes the duplication and makes the intent of each onClick immediately clear.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: apps/code/src/renderer/features/mcp-servers/components/parts/ServerDetailView.tsx
   Line: 251-307
   
   Comment:
   **Repeated inline expression violates OnceAndOnlyOnce**
   
   The expression `toolSearch ? filteredTools : undefined` (and the disabled predicate `bulkPending || filteredTools.length === 0`) are each written three times. Extracting them to local variables removes the duplication and makes the intent of each `onClick` immediately clear.
   
   
   
   How can I resolve this? If you propose a fix, please make it concise.

   Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/mcp-servers/components/parts/ServerDetailView.tsx:251-307
**Repeated inline expression violates OnceAndOnlyOnce**

The expression `toolSearch ? filteredTools : undefined` (and the disabled predicate `bulkPending || filteredTools.length === 0`) are each written three times. Extracting them to local variables removes the duplication and makes the intent of each `onClick` immediately clear.

```suggestion
            <Flex gap="2" align="center">
              <Text color="gray" className="text-[13px]">
                Set all:
              </Text>
              {(() => {
                const bulkTarget = toolSearch ? filteredTools : undefined;
                const isBulkDisabled = bulkPending || filteredTools.length === 0;
                return (
                  <>
                    <Tooltip
                      content={toolSearch ? "Approve filtered" : "Approve all"}
                    >
                      <IconButton
                        variant="soft"
                        color="green"
                        size="1"
                        disabled={isBulkDisabled}
                        onClick={() => setBulkApproval("approved", bulkTarget)}
                      >
                        <Check size={12} weight="bold" />
                      </IconButton>
                    </Tooltip>
```

_{Reviews (1): Last reviewed commit: "Support bulk actions on filtered tools" | Re-trigger Greptile}