Repository navigation
fix(orders): support YES-price confirmation (LIQ-578) - #19
Draft
shazam8253 wants to merge 1 commit into
Draft
shazam8253 wants to merge 1 commit into
shazam8253 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow typed clients to explicitly confirm YES-denominated order prices during the staged Retail API rollout. For NO at 0.05, send price 0.95 and priceIsYes: True. LIQ-578.
Validation: ruff check/format and mypy pass; all 294 tests pass locally. No live API calls.
Impact: SDK users can migrate without bypassing their types; every writer for an enrolled user must migrate, including YES modifies. Cost is two optional fields; existing runtime forwarding is reused unchanged.
Companions: gateway #2759, schema/proxy #2633, guide #521. Package publication and explicit enrollment remain separate. Draft; no merge, release or enrollment requested.