Skip to content

fix(orders): support YES-price confirmation (LIQ-578) - #19

Draft
shazam8253 wants to merge 1 commit into
mainfrom
shanti/liq-578-yes-price-confirmation
Draft

shazam8253 wants to merge 1 commit into
mainfrom
shanti/liq-578-yes-price-confirmation

Conversation

@shazam8253

Copy link
Copy Markdown

Allow typed clients to explicitly confirm YES-denominated order prices during the staged Retail API rollout. For NO at 0.05, send price 0.95 and priceIsYes: True. LIQ-578.

  • Add optional confirmation to create/modify TypedDicts, inherited by preview and batch entries. No automatic confirmation or conversion.
  • Clarify selected-outcome slippage references versus YES order/response prices.
  • Verify absent, false and true values through the real signed sync/async HTTP clients for create, modify, preview and batch writes. Existing batch wire fixtures now also carry explicit confirmation.

Validation: ruff check/format and mypy pass; all 294 tests pass locally. No live API calls.

Impact: SDK users can migrate without bypassing their types; every writer for an enrolled user must migrate, including YES modifies. Cost is two optional fields; existing runtime forwarding is reused unchanged.

Companions: gateway #2759, schema/proxy #2633, guide #521. Package publication and explicit enrollment remain separate. Draft; no merge, release or enrollment requested.

  • Authored/assisted by Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant