fix: improve SecKeyGeneratePair implementation in PlayChain#228
Open
viatearz wants to merge 3 commits into
Open
fix: improve SecKeyGeneratePair implementation in PlayChain#228viatearz wants to merge 3 commits into
viatearz wants to merge 3 commits into
Conversation
Contributor
Author
|
Now we are able to log in with PlayChain enabled and SIP enabled. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed several issues in PlayChain’s SecKeyGeneratePair implementation.
The changes are split into separate commits for clarity, they can be squashed.
First Issue
There is a mistake in the guard statement. The success check should be
== 0, not!= 0.Second issue
It does not assign the generated keys to the out pointers, so the caller always receives
nullfor both keys.Third Issue
The app may place
kSecAttrIsPermanent("perm = 1") at the root-level of the parameter dictionary, instead of insidekSecPrivateKeyAttrsorkSecPublicKeyAttrs. PlayChain should handle this case as well.