Skip to content

Fix hard coded user dir path - #221

Merged
JoseMoreville merged 1 commit into
PlayCover:masterfrom
Max-Sum:fix-user-dir
Aug 12, 2026
Merged

Fix hard coded user dir path#221
JoseMoreville merged 1 commit into
PlayCover:masterfrom
Max-Sum:fix-user-dir

Conversation

@Max-Sum

@Max-Sum Max-Sum commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

We should use NSHomeDirectoryForUser to get home dir instead of hard-coded /Users/ path.

@Max-Sum
Max-Sum force-pushed the fix-user-dir branch 3 times, most recently from eb99af6 to 90ca429 Compare April 19, 2026 17:38
Comment thread PlayTools/PlaySettings.swift
@TheMoonThatRises

Copy link
Copy Markdown
Member

@viatearz @Ryu-ga can you review the ue_fix_filename function as I have not personally dug deep into its mechanics?

@viatearz

viatearz commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

@viatearz @Ryu-ga can you review the ue_fix_filename function as I have not personally dug deep into its mechanics?

I've tested the ue_fix_filename function, it works fine.

@TheMoonThatRises TheMoonThatRises added the enhancement New feature or request label Aug 12, 2026

@JoseMoreville JoseMoreville left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right

@JoseMoreville
JoseMoreville merged commit 9942607 into PlayCover:master Aug 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants