Add initial implementation for native capsules - #4222
Draft
miguelh-nvidia wants to merge 1 commit into
Draft
miguelh-nvidia wants to merge 1 commit into
miguelh-nvidia wants to merge 1 commit into
Conversation
miguelh-nvidia
force-pushed
the
miguelh/native-capsule
branch
from
September 16, 2026 18:05
329835f to
12843b9
Compare
Collaborator
|
Filed as internal issue #USD-12640 (This is an automated message. See here for more information.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Adds an initial implementation for rendering native capsules in Storm, based (very closely) on the existing native sphere implementation. The main differences are the capsule-specific rprim parameters and the shader’s bounds, lateral-surface, and spherical-cap intersection calculations. The feature is guarded by HDST_ENABLE_NATIVE_CAPSULES and includes image tests.
AI assistance was used during the development of this PR. I reviewed the implementation, tests, and documentation and take full responsibility for the contribution.
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)