Bugfix/lambda capture cleanup - #4185
Open
HakeemAdam wants to merge 6 commits into
Open
HakeemAdam wants to merge 6 commits into
HakeemAdam wants to merge 6 commits into
Conversation
Removed unsused lambda captures to clean up compilation warnings with CLang
Removed two addtional instances, no occurence on clang build
nvmkuruc
reviewed
Aug 17, 2026
| @@ -467,7 +467,7 @@ HdxSelectionTracker::_GetSelectionOffsets(HdSelectionSharedPtr const &selection, | |||
|
|
|||
| size_t const N = 1000; | |||
Collaborator
There was a problem hiding this comment.
I'm curious if you should make N constexpr as well.
nvmkuruc
reviewed
Aug 17, 2026
| @@ -526,7 +526,7 @@ HdStCommandBuffer::SyncDrawItemVisibility(unsigned visChangeCount) | |||
Collaborator
There was a problem hiding this comment.
I'm curious if you should make N constexpr as well.
Author
There was a problem hiding this comment.
I think it makes sense, will amend it. Thanks for the suggestions
Addressing reviewers feedback. Changed removed capture variables to constexpr in line with modern C++ standards
Member
|
Filed as internal issue #USD-12566 ❗ Please make sure that a signed CLA has been submitted! (This is an automated message. See here for more information.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Removed a few instances of unused lambda captures, which are caught as build warnings on clang.
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)