Do not treat RSL warnings as errors - #175
Closed
Tobias-Fischer wants to merge 1 commit into
Closed
Conversation
This upstreams RoboStack downstream patch `patch/ros-rolling-rsl.patch`. Best-guess rationale: RSL_ENABLE_WARNINGS should enable diagnostic warnings without turning dependency or compiler-version warnings into hard build failures for downstream package builds. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Author
|
FYI @wep21 and @traversaro, this upstream PR comes from the RoboStack patch upstreaming tracker: RoboStack/robostack.github.io#16. Origin patch: RoboStack |
Collaborator
|
Are you sure that this compile option is passed to packages linking against RSL? I doubt so. I guess that some error within this package stops compilation on windows, maybe we can fix this properly? |
Author
|
@wep21 might know more :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of an effort to contribute RoboStack downstream patches back upstream.
Origin: RoboStack
patch/ros-rolling-rsl.patch, authored by Daisuke Nishimatsu.Best-guess rationale: RSL_ENABLE_WARNINGS should enable diagnostic warnings without turning dependency or compiler-version warnings into hard build failures for downstream package builds.