Failed-message list cannot be sorted by "Time of failure" — silently falls back to "Time sent"#5479
Merged
ramonsmits merged 2 commits intoMay 19, 2026
Conversation
The Primary instance global SortInfoModelBinder allowlist is missing the 'time_of_failure' and 'modified' sort keys. When ServicePulse requests the failed-message list sorted by Time of failure (sort=time_of_failure), the binder silently rewrites the token to 'time_sent', so the RavenDB layer — which does support TimeOfFailure ordering — never sees it. The list ends up ordered by Time sent regardless of the user's choice. This test reproduces the defect at the binder level (RED).
Add the two missing sort keys to the Primary instance SortInfoModelBinder allowlist so that sort=time_of_failure (and sort=modified) survive model binding and reach the RavenDB query, which already maps them to the TimeOfFailure / LastModified index fields. Fixes the ServicePulse failed-message list ordering by 'Time of failure', which previously fell back to 'Time sent'. (GREEN)
dvdstelt
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Backport of: