chore(notes-ui): delete the retired notes reference surface - #203
Merged
Conversation
Notes is retired (parachute-hub#788), but notes-ui kept living here — and worse, kept being SUGGESTED. The "add a surface" form's npm placeholder was literally `@openparachute/notes-ui[@Version]`, so the retired module was the worked example for what to install. A placeholder is a recommendation whether or not you intend it as one; that's how notes kept resurfacing inside surface long after it stopped being maintained. - placeholder -> `@scope/my-surface[@Version]`: a shape, not a package. - packages/notes-ui deleted (290 files). Nothing depended on it; it wasn't in the build script. - dropped from the root `test` + `typecheck` scripts and its two dedicated `test:`/`build:` scripts. - release lane removed: RELEASING.md rows, tag conventions, the "Releasing @openparachute/notes-ui" section, and the publish-notes-ui-npm CI job with its tag triggers. Removing `!startsWith(github.ref_name, 'notes-ui-')` from the app catch-all `if` is safe precisely because the `notes-ui-v*` tag triggers went with it — such a tag can no longer start the workflow at all. Published notes-ui versions stay on npm for anyone still installing one; nothing new ships from here. Noted in RELEASING.md along with dropping its npm Trusted Publisher rule. Workspace typecheck clean, all suites green (surface-render 69, admin 99, 0 fail across the root `test` script), release.yml still parses. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RPoTHLWtNvRVWYcs1K5i8b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the notes retirement started in ParachuteComputer/parachute-hub#788, on the surface side.
The actual "it surfaces inside of surface" bug
web/admin/src/routes/Add.tsxused@openparachute/notes-ui[@version]as the npm placeholder in the add-a-surface form. So the retired module was the worked example for what to install. A placeholder is a recommendation whether or not you intend it as one — that's how notes kept resurfacing inside surface long after it stopped being maintained.It now reads
@scope/my-surface[@version]: a shape, not a package. Nothing first-party to mistake for an endorsement.And the package itself
packages/notes-uiis deleted — 290 files. It was safe to remove outright, unlike hub's registry entry:@openparachute/notes-uiappears in no otherpackage.json),buildscript,Also removed:
test+typecheckscript entries, and the dedicatedtest:notes-ui/build:notes-uiscripts,RELEASING.mdpackage row, tag conventions, the "Releasing@openparachute/notes-ui" section, the tag-pattern troubleshooting mention, and the numbered Trusted-Publisher item (list renumbered),publish-notes-ui-npmCI job and itsnotes-ui-v*tag triggers.One subtlety worth a reviewer's eye: I dropped
!startsWith(github.ref_name, 'notes-ui-')from thepublish-surface-npmcatch-allif. That exclusion existed so anotes-ui-*tag wouldn't also fire the bare-v...app publish. It's safe to remove only because thenotes-ui-v*tag triggers went with it — such a tag can no longer start the workflow at all. If you'd rather keep the exclusion as belt-and-braces against a resurrected trigger, say so and I'll restore it.Published
notes-ui-v*versions stay on npm for anyone still installing one; nothing new ships from here. Recorded inRELEASING.md, along with the note that its npm Trusted Publisher rule can be dropped.Verification
bun run typecheck:allclean (root + admin).testscript: 0 fail across every remaining suite.web/adminvitest: 99 pass — including the Add-form tests, retargeted off the notes-ui placeholder.surface-render: 69 pass.release.ymlstill parses as valid YAML; six publish jobs remain, correctly bounded.Version
0.2.2→0.2.3(surface ships stable patch bumps, not rc, per workspace governance).🤖 Generated with Claude Code
https://claude.ai/code/session_01RPoTHLWtNvRVWYcs1K5i8b