fix(installer): use platform-specific yt-dlp config path#493
Draft
yupoet wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
get_ytdlp_config_path()when the installer configures the Node.js runtime for yt-dlp.--js-runtimes nodeunder~/Library/Application Support/yt-dlp/config.Why
In v1.5.0,
_install_system_deps()hardcodes the Linux path~/.config/yt-dlp/config, while the YouTube doctor check uses the platform-aware path helper. On macOS this makes installation report success, but the followingagent-reach doctorcannot find the setting and warns that the JS runtime is not configured.Using the existing shared helper keeps installation and health checks aligned on every supported platform.
User impact
After
agent-reach install --env=autoon macOS, YouTube readiness is detected correctly without requiring users to duplicate the yt-dlp setting manually.Validation
python3 -m pytest tests/ -q— 197 passedpython3 -m ruff check --select F401 agent_reach/cli.py tests/test_cli.py— passed